-
Notifications
You must be signed in to change notification settings - Fork 308
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DAOS-623 ci: Simplify the pull request template (#15969)
Document just the essentials Signed-off-by: Jeff Olivier <[email protected]> Co-authored-by: Dalton Bohning <[email protected]>
- Loading branch information
1 parent
6246853
commit 470603b
Showing
1 changed file
with
7 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,9 @@ | ||
### Before requesting gatekeeper: | ||
### Steps for the author: | ||
|
||
* [ ] Two review approvals and any prior change requests have been resolved. | ||
* [ ] Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set. | ||
* [ ] `Features:` (or `Test-tag*`) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR. | ||
* [ ] Commit messages follows the guidelines outlined [here](https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments). | ||
* [ ] Any tests skipped by the ticket being addressed have been run and passed in the PR. | ||
* [ ] Commit message follows the [guidelines](https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments). | ||
* [ ] Appropriate [Features or Test-tag](https://daosio.atlassian.net/wiki/spaces/DC/pages/10984259629/Test+Tags) pragmas were used. | ||
* [ ] At least two positive code reviews including at least one code owner from each category referenced in the PR. | ||
* [ ] Testing is complete. If necessary, forced-landing label added and a reason added in a comment. | ||
|
||
### Gatekeeper: | ||
|
||
* [ ] You are the appropriate gatekeeper to be landing the patch. | ||
* [ ] The PR has 2 reviews by people familiar with the code, including appropriate owners. | ||
* [ ] Githooks were used. If not, request that user install them and check copyright dates. | ||
* [ ] Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs. | ||
* [ ] All builds have passed. Check non-required builds for any new compiler warnings. | ||
* [ ] Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes. | ||
* [ ] If applicable, the PR has addressed any potential version compatibility issues. | ||
* [ ] Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket. | ||
* [ ] Extra checks if forced landing is requested | ||
* [ ] Review comments are sufficiently resolved, particularly by prior reviewers that requested changes. | ||
* [ ] No new NLT or valgrind warnings. Check the classic view. | ||
* [ ] Quick-build or Quick-functional is not used. | ||
* [ ] Fix the commit message upon landing. Check the standard [here](https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments). Edit it to create a single commit. If necessary, ask submitter for a new summary. | ||
#### After all prior steps are complete: | ||
* [ ] Gatekeeper requested (daos-gatekeeper added as a reviewer). |