Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect getting overwritten in localStorage #1067

Merged

Conversation

JerrettDavis
Copy link
Contributor

Issue #1060 refers to application's having their own internal redirect record in localStorage overwritten by the AutoLoginService. The StoragePersistenceService already handles prefixing stored values to remedy this issue. I've converted the AutoLoginService to use StoragePersistenceService instead of localStorage.

Issue damienbod#1060 refers to application's having their own internal `redirect` record in `localStorage` overwritten by the `AutoLoginService`. The `StoragePersistenceService` already handles prefixing stored values to remedy this issue. I've converted the `AutoLoginService` to use `StoragePersistenceService` instead of `localStorage`.
@FabianGosebrink FabianGosebrink mentioned this pull request Apr 25, 2021
19 tasks
@FabianGosebrink
Copy link
Collaborator

You are on fire! Thanks :-) We will look into this, a bit short of time currently, and then merge this. Thanks for your help, we really appreciate it!

@JerrettDavis
Copy link
Contributor Author

We've been using the library for a bit now, so I'm always happy to lend a hand. On that note, I still need to fix the unit tests before this can be merged. I should have that done shortly.

Also updated the various storage services to include a `clear` method.
@JerrettDavis
Copy link
Contributor Author

JerrettDavis commented Apr 25, 2021

I've updated all the necessary unit tests to make them compatible with the change away from localStorage. One minor change I implemented throughout was the inclusion of a clear method on the AbstractSecurityStorage class. This shouldn't be at all breaking, but it enables localStorage-based Unit Tests to perform post-test cleanup, if necessary. As it stands now, it shouldn't be necessary as the mock used for testing doesn't actually persist anything, but previously it was and I didn't want any sort of feature regression.

@FabianGosebrink
Copy link
Collaborator

Glad to hear that you are using the lib :-) Thanks for being part of this then :) We have to test the AutoLogin Good and the Popup. @damienbod and I will run the tests and then this will land in V12. Thanks!

@FabianGosebrink FabianGosebrink changed the base branch from releaseV12-WIP to main April 26, 2021 06:25
@FabianGosebrink FabianGosebrink changed the base branch from main to releaseV12-WIP April 26, 2021 06:26
@damienbod damienbod merged commit 7888a91 into damienbod:releaseV12-WIP Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants