Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features for V12 #1050

Closed
19 tasks done
FabianGosebrink opened this issue Apr 16, 2021 · 9 comments
Closed
19 tasks done

Features for V12 #1050

FabianGosebrink opened this issue Apr 16, 2021 · 9 comments

Comments

@FabianGosebrink
Copy link
Collaborator

FabianGosebrink commented Apr 16, 2021

V12 will be developed on this branch: ReleaseV12-WIP

Gathering all Issues and PRs which will be done in V12 and maybe are breaking changes

12.x

Issue: How to change configuration at runtime ? #923
Issue: Error handling support for better user experience #976

@julienvonoetinger-eaton

Hi,

Will this V12 support Angular 12 too ? I have tried to update my project to angular 12 and I have dependencies issues now.

@damienbod
Copy link
Owner

Hi @julien-von-oetinger yes.

For the moment you could just do a force update

Don't know why the breaking changes in V12 cause update problems but I was able to fix the peer dependencies by using force

ng update --force

@julienvonoetinger-eaton
Copy link

julienvonoetinger-eaton commented May 19, 2021

Thanks for the quick answer ! I'll try with force update.

For information, that's the error message I got:

npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR! @angular/common@"~12.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^11.0.5" from [email protected]
npm ERR! node_modules/angular-auth-oidc-client
npm ERR! angular-auth-oidc-client@"^11.6.9" from the root project

@FabianGosebrink
Copy link
Collaborator Author

We will address this, the lib will be V12 compatible. Please do not use this issue for Angular V12. This is V12 of this lib. But we are planning the compatibility of course. Make sure ngcc has run through the lib after installing it.

@damienbod damienbod mentioned this issue Jun 13, 2021
@damienbod
Copy link
Owner

party :) thanks for all the contributions, we are feature complete for Version 12

@damienbod damienbod unpinned this issue Jun 20, 2021
@damienbod damienbod reopened this Jul 2, 2021
@piechpatrick
Copy link

When can we expect release v12?

@damienbod
Copy link
Owner

damienbod commented Jul 3, 2021

Hopefully soon. We discovered an issue when testing and doing the migration tests.

Only one returntype (object) when subscribing to isAuthenticated and userdata to avoid confusion #1164

PR #1165

So we must fix this first and do the testing again. @FabianGosebrink needs to finish the PR, then testing and we're ready to release.

@FabianGosebrink
Copy link
Collaborator Author

FabianGosebrink commented Jul 3, 2021

We're close. Planning to do some work on it today. See how far I come. Unit Tests and then testing the samples.

@damienbod
Copy link
Owner

released, thanks for all the support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants