This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Change to launch multiple tasks if offer is big enough #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al order of AppResource.
newTasks was changed to try to take tasks from taskQueue as many as possible.
…resourced but original offered resource. To take tasks as many as possible from taskQueue, task should be generated based on remained resource.
…o TaskBuilder. Consequently, TaskScheduler(taskQueue,newTaskId).buildUtmostTasksFor(offer) was introduced.
In TaskBuilder class, meetsConstraints(AppDefinition, Offer) was introduced. Consequently, offerMatches in TaskBuilder object was deleted.
…aged tasks to the sequence id.
|
Is this still a feature worth adding? |
|
Thanks for pinging me @ssorallen . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for #14 was originally pushed on a branch
patch/issue-14(#23).But, the branch was based on old commit and merging the branch to master requires us to resolve some conflicts and refactoring. So, I've make merging branch
merge-patch-issue-14for making this patch to be mergable to master.