This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Change to launch multiple tasks if offer is big enough #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al order of AppResource.
newTasks was changed to try to take tasks from taskQueue as many as possible.
…resourced but original offered resource. To take tasks as many as possible from taskQueue, task should be generated based on remained resource.
…o TaskBuilder. Consequently, TaskScheduler(taskQueue,newTaskId).buildUtmostTasksFor(offer) was introduced.
| } | ||
|
|
||
| // AppDefinition can be viewed as AppResource | ||
| implicit def AppDefinition2AppResource(app: AppDefinition) |
There was a problem hiding this comment.
clean up formatting here, use {} for method def and if/else
|
This branch needs to resolve some conflicts and refactoring for merging to master. |
jasongilanfarr
pushed a commit
that referenced
this pull request
Jun 16, 2016
* Make LaunchQueue unopinionated towards AppDefinitions. * Introduced RunSpec trait * renamed properties to RunSpec * Minor changes * removed unused dependency * fixed comment * Fixed potential issue in TaskBuilder * addressed review comments
aquamatthias
pushed a commit
that referenced
this pull request
Jun 17, 2016
* Make LaunchQueue unopinionated towards AppDefinitions. * Introduced RunSpec trait * renamed properties to RunSpec * Minor changes * removed unused dependency * fixed comment * Fixed potential issue in TaskBuilder * addressed review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I've tried to make a patch for #14.
Belows are summary of my patch:
Could you review my commits and let me have your comments?