-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixing m1 installation issues for m1 macs #20345
Conversation
Thanks for taking the time to open a PR!
|
circle.yml
Outdated
- chore/beta-release-m1-support | ||
- fix-darwin-win32-node-modules-install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JessicaSachs You'll want to leave the 10.0-release branch since this would erase those rules when it merges into 10.0-release. You'll want to replace anywhere that fix-darwin-win32-node-modules-install
is written with this branch: chore/beta-release-m1-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reverting this change completely after i test.
I added a commit really quick to build and test this. I'll take it out after I test manually. Don't merge until then.
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…/cypress into chore/beta-release-m1-support
I manually tested. Installing the beta build channel for m1 chips works now. In the future we should have an integration test with a real machine spun up by MacStadium, but I think that'll happen once we tackle the native Apple Silicone support. |
Solution
Because
download.js
works fine since it usesarch()
instead ofos.arch()
we should just updateinstall.js
to do the same thing for the beta channel.This fix is unrelated to any of the rosetta issues or any native support for m1... it just brings Beta channel installation in parity with the prod builds.
Testing
I can test this locally once it's merged into 10.0-release, but ideally we can get this branch building the beta channel, but I'm not really sure how to set this up for random branches. @flotwig maybe?I added a commit really quick to build and test this. I'll take it out after I test manually. Don't merge until then.