Minor fixes #596
Merged
Minor fixes #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cda5c2c.
nirandaperera
added a commit
that referenced
this pull request
Aug 19, 2022
#592) * Implement Slice, Head and Tail Operation in both centralize and distributed environment Signed-off-by: Arup Sarker <[email protected]> * Add Distributed Slice with arrow api Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Implementation of Distributive Slice, Head and Tail Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Revert the changes based on the upstream Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Implement Slice with new Logic Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Implement new logic for slice and add a basic test case Signed-off-by: Arup Sarker <[email protected]> * Update cpp/src/cylon/table.cpp Co-authored-by: niranda perera <[email protected]> * Update cpp/src/cylon/table.cpp Co-authored-by: niranda perera <[email protected]> * Update cpp/src/cylon/table.cpp Co-authored-by: niranda perera <[email protected]> * Update cpp/src/examples/CMakeLists.txt Co-authored-by: niranda perera <[email protected]> * [Cylon] Removed unneccessary data copy and logs Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Fix merge conflict Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Refactoring Slice logic into seperate file Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Update new test cases Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Add multiple test cases for slice operation Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Refactoring slice operation Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Fix error message and un-necessary example files Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Implement tail operation with new logic Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Implement Tail operation by fixing the logic Signed-off-by: Arup Sarker <[email protected]> * Add sliceImple methods and clear unnecessary logs Signed-off-by: Arup Sarker <[email protected]> * [Cylon] Change the output table parameter from address to pointer Signed-off-by: Arup Sarker <[email protected]> * Squashing following commits removing std out fixing errors more logs more logs adding logs attempting to fix macos error cosmetic changes cosmetic changes * Minor fixes (#596) * remove gloo default hostname * minor change gloo * adding gloo-mpi test * adding ucc cyton * Update setup.py * Update setup.py * adding ucc test * adding multi env test * cosmetic changes * adding regular sampling cython * adding UCC barrier * adding macos11 tag for CI * fixing windows error * trying to fix macos ci * trying to fix macos issue * Revert "trying to fix macos issue" This reverts commit cda5c2c. * attempting to fix macos ci * style-check * adding gloo timeout * adding custom mpiexec cmake var * [Cylon] Handle corner case for slice test Signed-off-by: Arup Sarker <[email protected]> * Create README-summit.md (#602) * Create README-summit.md Detailed description of how to compile cylon on summit * Update README-summit.md * Update README-summit.md * Update README-summit.md (#603) add cmake path * adding custom mpirun params cmake var (#604) * adding custom mpirun params cmake var * minor change * changing merge to support empty tables Signed-off-by: Arup Sarker <[email protected]> Co-authored-by: niranda perera <[email protected]> Co-authored-by: Gregor von Laszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.