Implement Slice, Head and Tail Operation in both centralize and distr… #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibuted environment Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
nirandaperera
requested changes
Jul 15, 2022
Signed-off-by: Arup Sarker <[email protected]>
nirandaperera
requested changes
Jul 20, 2022
Signed-off-by: Arup Sarker <[email protected]>
nirandaperera
requested changes
Jul 21, 2022
Co-authored-by: niranda perera <[email protected]>
Co-authored-by: niranda perera <[email protected]>
Co-authored-by: niranda perera <[email protected]>
Co-authored-by: niranda perera <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
nirandaperera
requested changes
Jul 31, 2022
cpp/src/cylon/table.cpp
Outdated
| @@ -1467,8 +1472,11 @@ Status Equals(const std::shared_ptr<cylon::Table> &a, const std::shared_ptr<cylo | |||
| static Status RepartitionToMatchOtherTable(const std::shared_ptr<cylon::Table> &a, | |||
There was a problem hiding this comment.
Please remove these logs
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
|
@arupcsedu can you reformat the code with Google style with 100 characters per line? VS Code should do this automatically once you set the style |
|
Sure I will.
…On Wed, 3 Aug, 2022 at 5:04 PM, niranda perera ***@***.***> wrote:
@arupcsedu <https://github.com/arupcsedu> can you reformat the code with
Google style with 100 characters per line? VS Code should do this
automatically once you set the style
—
Reply to this email directly, view it on GitHub
<#592 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOGXWTFU4AI6K2RN4FIOUDVXLNG5ANCNFSM5Z2PWEKA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I set it with VSCode. But it formats the code to display in the editor. No
actual change in the source file.
…On Wed, Aug 3, 2022 at 5:05 PM Arup Sarker ***@***.***> wrote:
Sure I will.
On Wed, 3 Aug, 2022 at 5:04 PM, niranda perera ***@***.***>
wrote:
> @arupcsedu <https://github.com/arupcsedu> can you reformat the code with
> Google style with 100 characters per line? VS Code should do this
> automatically once you set the style
>
> —
> Reply to this email directly, view it on GitHub
> <#592 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACOGXWTFU4AI6K2RN4FIOUDVXLNG5ANCNFSM5Z2PWEKA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
removing std out fixing errors more logs more logs adding logs attempting to fix macos error cosmetic changes cosmetic changes
* remove gloo default hostname * minor change gloo * adding gloo-mpi test * adding ucc cyton * Update setup.py * Update setup.py * adding ucc test * adding multi env test * cosmetic changes * adding regular sampling cython * adding UCC barrier * adding macos11 tag for CI * fixing windows error * trying to fix macos ci * trying to fix macos issue * Revert "trying to fix macos issue" This reverts commit cda5c2c. * attempting to fix macos ci * style-check * adding gloo timeout * adding custom mpiexec cmake var
Signed-off-by: Arup Sarker <[email protected]>
* Create README-summit.md Detailed description of how to compile cylon on summit * Update README-summit.md * Update README-summit.md
add cmake path
* adding custom mpirun params cmake var * minor change
|
@arupcsedu this looks good now. I made some minor improvements. I'll merge this after CI jobs. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ibuted environment
Signed-off-by: Arup Sarker [email protected]