Raise error if there is a relative path in global.cylc[install]source dirs
#4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
force-pushed
the
rel-source-dirs
branch
from
a4f077d to
443ae77
Compare
MetRonnie
force-pushed
the
rel-source-dirs
branch
from
443ae77 to
e7bddf8
Compare
MetRonnie
commented
May 20, 2022
Comment on lines
+1507
to
+1508
| # Flesh out with defaults | ||
| self.expand() |
There was a problem hiding this comment.
This doesn't change the code actually, just makes it clearer - self._set_default_editors() was doing the expansion all this time
MetRonnie
commented
May 20, 2022
| if keys: | ||
| for key in keys: | ||
| try: | ||
| cfg = cfg[key] | ||
| except (KeyError, TypeError): | ||
| if parents in self.manyparents or key in self.get(parents): |
There was a problem hiding this comment.
This self.get() was expanding the config this whole time
datamel
approved these changes
May 24, 2022
wxtim
approved these changes
May 24, 2022
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
May 27, 2022
* 'master' of https://github.com/cylc/cylc: (47 commits) Global platform default directives (cylc#4896) Raise an error if the user tries to set owner. (cylc#4860) Raise error if there is a relative path in `global.cylc[install]source dirs` (cylc#4887) Added a noqa tag to a new flake8-simplify case. (cylc#4895) Update change log. Don't prompt to clean no workflows. Bump to next dev version Fix task matching bug (cylc#4881) Expand comma separated platform names correctly (cylc#4880) resolvers: add a couple of comments Prepare release 8.0rc3 Fix change log. Add & amalgamate jinja2 error tests shellcheck fix Tweak show help text. Fix wrong context lines for jinja2 error Fix missing context lines for jinja2 error Improve new func. test. Syntax highlighting: don't symlink files now they are extracted using cylc get-resources Emacs syntax highlighting: fix filename pattern matching ...
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #4815
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.