Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traceback in cylc config -i #6062

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix traceback in cylc config -i #6062

merged 3 commits into from
Apr 23, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Apr 10, 2024

Closes #6010

Fixes bug when trying to get a setting in a __MANY__ section when the setting is valid but not set in the config.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry not particularly needed
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added bug Something is wrong :( small labels Apr 10, 2024
@MetRonnie MetRonnie added this to the 8.2.6 milestone Apr 10, 2024
@MetRonnie MetRonnie requested a review from wxtim April 10, 2024 11:02
@MetRonnie MetRonnie self-assigned this Apr 10, 2024
@MetRonnie MetRonnie linked an issue Apr 10, 2024 that may be closed by this pull request
@MetRonnie
Copy link
Member Author

MetRonnie commented Apr 10, 2024

I love Parsec... 😕

Edit: problem fixed now

@MetRonnie MetRonnie marked this pull request as draft April 10, 2024 13:16
@MetRonnie MetRonnie marked this pull request as ready for review April 10, 2024 16:54
@MetRonnie MetRonnie removed the small label Apr 10, 2024
@hjoliver
Copy link
Member

I love Parsec... 😕

Sorry 😬 (I wrote it years ago to fix deficiencies and slow performance of the 3rd party library we originally used, but it leaves much to be desired!)

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've pointed to one check which I think may be unecessary, but I don't think it's a blocker. :)

print(f'{PLATFORM_REGEX_TEXT}\n\nPlatforms\n---------', file=stderr)
print(platforms)
print('\n\nPlatform Groups\n--------------', file=stderr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this extra newline was probably present for compliance with ReST code style.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being used in the docs somewhere?

Copy link
Member

@wxtim wxtim Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be pointless using it in the Cylc Docs, but I could imagine feeding it into metomi docs. I don't think that we do that at the moment, though.

This will have mostly been about what looked good to me.

@oliver-sanders
Copy link
Member

(one test to fix)

Fixes bug when trying to get a setting in a `__MANY__` section when the setting is valid but not set in the config.
@MetRonnie
Copy link
Member Author

@wxtim I've changed tack, please re-review. (Diff: https://github.com/cylc/cylc-flow/compare/a87150864721b67496f48c35c680d48f084f948a..f43126bee4a64730458391fb400e6edf8fc00409)

@MetRonnie MetRonnie requested a review from wxtim April 11, 2024 15:10
@MetRonnie
Copy link
Member Author

Bump @wxtim

@wxtim wxtim merged commit ecf9e78 into cylc:8.2.x Apr 23, 2024
21 of 23 checks passed
@MetRonnie MetRonnie deleted the config-bug branch April 23, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cylc config -i traceback
4 participants