-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix traceback in cylc config -i
#6062
Conversation
I love Parsec... 😕 Edit: problem fixed now |
Sorry 😬 (I wrote it years ago to fix deficiencies and slow performance of the 3rd party library we originally used, but it leaves much to be desired!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've pointed to one check which I think may be unecessary, but I don't think it's a blocker. :)
print(f'{PLATFORM_REGEX_TEXT}\n\nPlatforms\n---------', file=stderr) | ||
print(platforms) | ||
print('\n\nPlatform Groups\n--------------', file=stderr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this extra newline was probably present for compliance with ReST code style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being used in the docs somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be pointless using it in the Cylc Docs, but I could imagine feeding it into metomi docs. I don't think that we do that at the moment, though.
This will have mostly been about what looked good to me.
(one test to fix) |
Fixes bug when trying to get a setting in a `__MANY__` section when the setting is valid but not set in the config.
@wxtim I've changed tack, please re-review. (Diff: https://github.com/cylc/cylc-flow/compare/a87150864721b67496f48c35c680d48f084f948a..f43126bee4a64730458391fb400e6edf8fc00409) |
Bump @wxtim |
Closes #6010
Fixes bug when trying to get a setting in a
__MANY__
section when the setting is valid but not set in the config.Check List
CONTRIBUTING.md
and added my name as a Code Contributor.CHANGES.md
entry not particularly needed?.?.x
branch.