Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Use canonical file name to create FileOutputStream for plugins #2482

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

violplayer
Copy link
Contributor

#2108

Describe the solution you have implemented
Variables file and canonicalFile should be the file on the file system. Native code throws Exception when opening file.
canonicalFile is possible.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #2482 (4d389cf) into main (3ae4f02) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2482   +/-   ##
=========================================
  Coverage     83.70%   83.70%           
  Complexity     2677     2677           
=========================================
  Files           319      319           
  Lines          9438     9438           
  Branches        916      916           
=========================================
  Hits           7900     7900           
  Misses         1201     1201           
  Partials        337      337           
Impacted Files Coverage Δ
...in/java/io/cucumber/core/plugin/PluginFactory.java 74.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae4f02...4d389cf. Read the comment docs.

@mpkorstanje mpkorstanje changed the title Fix for bug from issue 2108 [Core] Use canonical file name to create FileOutputStream for plugins Feb 17, 2022
@mpkorstanje mpkorstanje merged commit 27befc8 into cucumber:main Feb 17, 2022
@aslakhellesoy
Copy link
Contributor

Hi @violplayer,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants