Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous Unsaved Dialog #928

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Conversation

egbicker
Copy link
Contributor

@egbicker egbicker commented Oct 19, 2023

Fixes notifications about unsaved changes that do not exist.

Closes #927

@jw3
Copy link
Member

jw3 commented Oct 20, 2023

@egbicker the rules view is fixed, but the config view still seems to have the same problem.

@jw3
Copy link
Member

jw3 commented Oct 22, 2023

@egbicker the notification occurs only when there is invalid config in the editor. Follow up PR will address the lack of notification of syntax error.

@jw3 jw3 added this to the v1.2 milestone Oct 22, 2023
@jw3 jw3 merged commit b8528df into ctc-oss:master Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erroneous unsaved changes prompts
2 participants