Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous unsaved changes prompts #927

Closed
jw3 opened this issue Oct 19, 2023 · 1 comment · Fixed by #928
Closed

Erroneous unsaved changes prompts #927

jw3 opened this issue Oct 19, 2023 · 1 comment · Fixed by #928
Assignees
@egbicker
Labels
bug Something isn't working
Milestone
v1.2

Comments

@jw3
Copy link
Member

jw3 commented Oct 19, 2023

Looks like #921 may have included an issue with prompting for unsaved changes even when there are no unsaved changes.

  1. Edit rules on config
  2. Save
  3. Navigate away
  4. Observe prompt
@jw3 jw3 added the bug Something isn't working label Oct 19, 2023
@jw3 jw3 added this to the v1.2 milestone Oct 19, 2023
@jw3
Copy link
Member Author

jw3 commented Oct 19, 2023

image

@jw3 jw3 mentioned this issue Oct 22, 2023
Merged
@jw3 jw3 closed this as completed in #928 Oct 22, 2023
jw3 pushed a commit that referenced this issue Oct 22, 2023
@egbicker
Erroneous Unsaved Dialog (#928)
b8528df 
Fixes notifications about unsaved changes that do not exist.

Closes #927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egbicker egbicker

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

Erroneous Unsaved Dialog egbicker/fapolicy-analyzer
2 participants
@jw3 @egbicker