reduce npm run invocations #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cli
common-tools
experimental
plugin-packs/postcss-preset-env
plugins/css-blank-pseudo
plugins/css-has-pseudo
plugins/css-prefers-color-scheme
plugins/media-queries-aspect-ratio-number-values
github-actions
bot
added
plugins/postcss-hwb-function
plugins/postcss-font-format-keywords
plugins/postcss-normalize-display-values
plugins/postcss-color-function
plugins/postcss-progressive-custom-properties
plugins/postcss-oklab-function
plugins/postcss-cascade-layers
plugins/postcss-ic-unit
plugins/postcss-unset-value
plugins/postcss-gradients-interpolation-method
plugins/postcss-stepped-value-functions
romainmenke
deleted the
reduce-npm-run-invocations--impartial-pied-tamarin-0603b84d45
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm runapparently has a high invocation cost. See : https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-4/We had a lot of scripts that we didn't call directly but only existed to have some structure. e.g.
"script-foo": "npm run script-foo:a && script-foo:b"Unwrapping those and calling the scripts/functions directly resulted in a nice speedup.
The same principles could be applied to
eslint.Linting our code base individual packages doesn't make much sense because the linter doesn't do any whole program analysis. It only enforces a coding style.
We can run
eslintfrom the root on all source files which is much faster because we save on startup costs.