reduce npm run invocations (#893)

* reduce npm run invocations

* remove more invocations

* run eslint once for the entire repo

* fix

* fix

.eslintrc.json

@@ -8,6 +8,7 @@
 		"ecmaVersion": 2022,
 		"sourceType": "module"
 	},
+	"ignorePatterns": ["**/dist/*"],
 	"rules": {
 		"quotes": ["error", "single"],
 		"comma-dangle": ["error", "always-multiline"],
@@ -21,7 +22,9 @@
 	"overrides": [
 		{
 			"files": [
-				"**/*.ts"
+				"**/*.ts",
+				"**/*.mts",
+				"**/*.cts"
 			],
 			"extends": [
 				"plugin:@typescript-eslint/eslint-recommended",

.github/workflows/lint.yml

@@ -0,0 +1,38 @@
+name: lint
+on:
+  push:
+    branches:
+    - 'main'
+  pull_request:
+  workflow_dispatch:
+    inputs:
+      build_and_test_all_packages:
+        type: boolean
+        description: Lint all packages
+        required: true
+
+concurrency:
+  group: branch-node--lint--${{ github.ref }}
+  cancel-in-progress: true
+
+defaults:
+  run:
+    shell: bash
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 1
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+
+      - name: npm ci
+        run: |
+          npm ci --ignore-scripts
+
+      - name: lint
+        run: npm run lint

.github/workflows/test.yml

@@ -12,7 +12,7 @@ on:
         required: true
 
 concurrency:
-  group: branch-node-${{ github.ref }}
+  group: branch-node--test--${{ github.ref }}
   cancel-in-progress: true
 
 defaults:
@@ -66,18 +66,14 @@ jobs:
           GITHUB_ACTION_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-        # Build, lint and PostCSS Tape tests must all work and pass :
+        # Build and PostCSS Tape tests must all work and pass :
         # - with exact dependencies from package-lock.json
         # - without requiring postinstall scripts from dependencies to run
       - name: build
         run: |
           npm run build --if-present $MODIFIED_WORKSPACES
         if: matrix.is_base_node_version && matrix.is_base_os_version
 
-      - name: lint
-        run: npm run lint --if-present $MODIFIED_WORKSPACES
-        if: matrix.is_base_node_version && matrix.is_base_os_version
-
       - name: docs
         run: npm run docs --if-present $MODIFIED_WORKSPACES
         if: matrix.is_base_node_version && matrix.is_base_os_version

cli/csstools-cli/package.json

@@ -76,16 +76,11 @@
 		"@csstools/base-cli": "0.1.0"
 	},
 	"scripts": {
-		"prebuild": "npm run clean",
 		"build": "rollup -c ../../rollup/default.mjs && npm run set-cli-file-permissions",
-		"clean": "node -e \"fs.rmSync('./dist', { recursive: true, force: true }); fs.mkdirSync('./dist');\"",
 		"csstools-cli": "csstools-cli",
-		"lint": "npm run lint:eslint && npm run lint:package-json",
-		"lint:eslint": "eslint ./src --ext .js --ext .ts --ext .mjs --no-error-on-unmatched-pattern",
-		"lint:package-json": "node ../../.github/bin/format-package-json.mjs",
-		"prepublishOnly": "npm run clean && npm run build && npm run test",
+		"lint": "node ../../.github/bin/format-package-json.mjs",
+		"prepublishOnly": "npm run build && npm run test",
 		"set-cli-file-permissions": "chmod a+x ./dist/cli.cjs",
-		"stryker": "stryker run --logLevel error",
 		"test": "exit 0",
 		"test:cli": "bash ./test/cli/test.sh"
 	},

e2e/interop/custom-media--design-tokens--global-data/package.json

@@ -4,8 +4,8 @@
 	"private": true,
 	"description": "Can you use custom-media, design-tokens and global-data together?",
 	"scripts": {
-		"build": "postcss style.css -o ./result.css",
-		"watch": "postcss style.css -w -o ./result.css",
+		"build": "postcss style.css -o ./dist/result.css",
+		"watch": "postcss style.css -w -o ./dist/result.css",
 		"test": "node ./test.mjs"
 	},
 	"devDependencies": {

e2e/interop/custom-media--design-tokens--global-data/test.mjs

@@ -1,7 +1,7 @@
 import assert from 'assert';
 import fs from 'fs/promises';
 
-const result = await fs.readFile('./result.css');
+const result = await fs.readFile('./dist/result.css');
 const expect = await fs.readFile('./expect.css');
 
 assert.equal(result.toString(), expect.toString());

e2e/postcss-cli/commonjs/package.json

@@ -4,7 +4,7 @@
 	"private": true,
 	"description": "Can you use postcss-cli with one of our plugins?",
 	"scripts": {
-		"build": "postcss style.css -o ./result.css",
+		"build": "postcss style.css -o ./dist/result.css",
 		"test": "node ./test.mjs"
 	},
 	"devDependencies": {

e2e/postcss-cli/commonjs/test.mjs

@@ -1,7 +1,7 @@
 import assert from 'assert';
 import fs from 'fs/promises';
 
-const result = await fs.readFile('./result.css');
+const result = await fs.readFile('./dist/result.css');
 const expect = await fs.readFile('./expect.css');
 
 assert.equal(result.toString(), expect.toString());

e2e/postcss-cli/esm/package.json

@@ -4,7 +4,7 @@
 	"private": true,
 	"description": "Can you use postcss-cli with one of our plugins?",
 	"scripts": {
-		"build": "postcss style.css -o ./result.css",
+		"build": "postcss style.css -o ./dist/result.css",
 		"test": "node ./test.mjs"
 	},
 	"devDependencies": {

e2e/postcss-cli/esm/test.mjs

@@ -1,7 +1,7 @@
 import assert from 'assert';
 import fs from 'fs/promises';
 
-const result = await fs.readFile('./result.css');
+const result = await fs.readFile('./dist/result.css');
 const expect = await fs.readFile('./expect.css');
 
 assert.equal(result.toString(), expect.toString());

e2e/typescript/commonjs/.gitignore

@@ -1,2 +0,0 @@
-index.cjs
-index.d.cts

e2e/typescript/commonjs/dist/index.cjs

@@ -0,0 +1,7 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const assert = require('assert');
+const plugin = require('postcss-preset-env');
+plugin({ preserve: true });
+assert.ok(plugin.postcss, 'should have "postcss flag"');
+assert.equal(typeof plugin, 'function', 'should return a function');

e2e/typescript/commonjs/package.json

@@ -5,7 +5,7 @@
 	"description": "Can you use PostCSS with one of our plugins from a Typescript file?",
 	"scripts": {
 		"build": "tsc",
-		"test": "node ./index.cjs"
+		"test": "node ./dist/index.cjs"
 	},
 	"devDependencies": {
 		"postcss-preset-env": "file:../../../plugin-packs/postcss-preset-env",

e2e/typescript/commonjs/tsconfig.json

@@ -3,11 +3,11 @@
 		"allowJs": false,
 		"allowSyntheticDefaultImports": true,
 		"declaration": true,
-		"declarationDir": ".",
+		"declarationDir": "./dist",
 		"lib": ["es2020"],
 		"module": "CommonJS",
 		"moduleResolution": "classic",
-		"outDir": ".",
+		"outDir": "./dist",
 		"target": "es2020",
 		"strict": true
 	},

e2e/typescript/esm--node-next/.gitignore

@@ -1,2 +0,0 @@
-index.mjs
-index.d.mts

e2e/typescript/esm--node-next/dist/index.d.ts

@@ -0,0 +1 @@
+export {};

e2e/typescript/esm--node-next/tsconfig.json

@@ -3,11 +3,11 @@
 		"allowJs": false,
 		"allowSyntheticDefaultImports": true,
 		"declaration": true,
-		"declarationDir": ".",
+		"declarationDir": "./dist",
 		"lib": ["es2020"],
 		"module": "ES6",
 		"moduleResolution": "nodenext",
-		"outDir": ".",
+		"outDir": "./dist",
 		"target": "es2020",
 		"strict": true
 	},

e2e/typescript/esm/.gitignore

@@ -1,2 +0,0 @@
-index.mjs
-index.d.mts

e2e/typescript/esm/dist/index.d.mts

@@ -0,0 +1 @@
+export {};

e2e/typescript/esm/dist/index.mjs

@@ -0,0 +1,5 @@
+import assert from 'assert';
+import plugin from 'postcss-preset-env';
+plugin({ preserve: true });
+assert.ok(plugin.postcss, 'should have "postcss flag"');
+assert.equal(typeof plugin, 'function', 'should return a function');

e2e/typescript/esm/package.json

@@ -5,7 +5,7 @@
 	"description": "Can you use PostCSS with one of our plugins from a Typescript file?",
 	"scripts": {
 		"build": "tsc",
-		"test": "node ./index.mjs"
+		"test": "node ./dist/index.mjs"
 	},
 	"devDependencies": {
 		"postcss-preset-env": "file:../../../plugin-packs/postcss-preset-env",

e2e/typescript/esm/tsconfig.json

@@ -3,11 +3,11 @@
 		"allowJs": false,
 		"allowSyntheticDefaultImports": true,
 		"declaration": true,
-		"declarationDir": ".",
+		"declarationDir": "./dist",
 		"lib": ["es2020"],
 		"module": "ES6",
 		"moduleResolution": "node",
-		"outDir": ".",
+		"outDir": "./dist",
 		"target": "es2020",
 		"strict": true
 	},

experimental/css-has-pseudo/package.json

@@ -42,16 +42,11 @@
 		"@csstools/postcss-tape": "*"
 	},
 	"scripts": {
-		"prebuild": "npm run clean",
 		"build": "rollup -c ../../rollup/default.mjs",
-		"clean": "node -e \"fs.rmSync('./dist', { recursive: true, force: true }); fs.mkdirSync('./dist');\"",
-		"lint": "npm run lint:eslint && npm run lint:package-json",
-		"lint:eslint": "eslint ./src --ext .js --ext .ts --ext .mjs --no-error-on-unmatched-pattern",
-		"lint:package-json": "node ../../.github/bin/format-package-json.mjs",
-		"prepublishOnly": "npm run clean && npm run build && npm run test",
+		"lint": "node ../../.github/bin/format-package-json.mjs",
+		"prepublishOnly": "npm run build && npm run test",
 		"stryker": "stryker run --logLevel error",
-		"test": "node .tape.mjs && npm run test:exports",
-		"test:exports": "node ./test/_import.mjs && node ./test/_require.cjs",
+		"test": "node .tape.mjs && node ./test/_import.mjs && node ./test/_require.cjs",
 		"test:rewrite-expects": "REWRITE_EXPECTS=true node .tape.mjs"
 	},
 	"homepage": "https://github.com/csstools/postcss-plugins/tree/main/experimental/css-has-pseudo#readme",

experimental/postcss-nesting/package.json

@@ -35,16 +35,11 @@
 		"@csstools/postcss-tape": "*"
 	},
 	"scripts": {
-		"prebuild": "npm run clean",
 		"build": "rollup -c ../../rollup/default.mjs",
-		"clean": "node -e \"fs.rmSync('./dist', { recursive: true, force: true }); fs.mkdirSync('./dist');\"",
 		"docs": "node ../../.github/bin/generate-docs/install.mjs",
-		"lint": "npm run lint:eslint && npm run lint:package-json",
-		"lint:eslint": "eslint ./src --ext .js --ext .ts --ext .mjs --no-error-on-unmatched-pattern",
-		"lint:package-json": "node ../../.github/bin/format-package-json.mjs",
-		"prepublishOnly": "npm run clean && npm run build && npm run test",
-		"test": "node .tape.mjs && npm run test:exports",
-		"test:exports": "node ./test/_import.mjs && node ./test/_require.cjs",
+		"lint": "node ../../.github/bin/format-package-json.mjs",
+		"prepublishOnly": "npm run build && npm run test",
+		"test": "node .tape.mjs && node ./test/_import.mjs && node ./test/_require.cjs",
 		"test:rewrite-expects": "REWRITE_EXPECTS=true node .tape.mjs"
 	},
 	"homepage": "https://github.com/csstools/postcss-plugins/tree/main/plugins/postcss-nesting#readme",

package.json

@@ -38,13 +38,9 @@
 	},
 	"scripts": {
 		"build": "npm run build --workspaces --if-present",
-		"clean": "bash ./.github/bin/clean.sh",
+		"clean": "npm run clean --workspaces --if-present",
 		"docs": "npm run docs --workspaces --if-present",
-		"lint": "npm run lint --workspaces --if-present && npm run lint:rollup-config && npm run lint:executable-files && npm run lint:licenses",
-		"lint:executable-files": "bash .github/bin/detect-executable-files/detect-executable-files.sh",
-		"lint:glue-scripts": "eslint ./.github/bin --ext .js --ext .ts --ext .mjs --no-error-on-unmatched-pattern",
-		"lint:licenses": "node .github/bin/license/check-license.mjs",
-		"lint:rollup-config": "eslint ./rollup --ext .js --ext .ts --ext .mjs --no-error-on-unmatched-pattern",
+		"lint": "npm run lint --workspaces --if-present && eslint ./ --ext .js --ext .mjs --ext .cjs --ext .ts --ext .mts --no-error-on-unmatched-pattern && bash .github/bin/detect-executable-files/detect-executable-files.sh && node .github/bin/license/check-license.mjs",
 		"new-plugin": "node ./.github/bin/new-plugin.mjs",
 		"release-plan": "node .github/bin/release-plan/release-plan.mjs",
 		"release-plan:dry-run": "node .github/bin/release-plan/release-plan.mjs --dry-run",

packages/base-cli/package.json

@@ -22,13 +22,10 @@
 		"postcss": "^8.4"
 	},
 	"scripts": {
-		"prebuild": "npm run clean",
+		"prebuild": "node -e \"fs.rmSync('./dist', { recursive: true, force: true }); fs.mkdirSync('./dist');\"",
 		"build": "tsc",
-		"clean": "node -e \"fs.rmSync('./dist', { recursive: true, force: true }); fs.mkdirSync('./dist');\"",
-		"lint": "npm run lint:eslint && npm run lint:package-json",
-		"lint:eslint": "eslint ./src --ext .js --ext .ts --ext .mjs --no-error-on-unmatched-pattern",
-		"lint:package-json": "node ../../.github/bin/format-package-json.mjs",
-		"prepublishOnly": "npm run clean && npm run build && npm run test",
+		"lint": "node ../../.github/bin/format-package-json.mjs",
+		"prepublishOnly": "npm run build && npm run test",
 		"stryker": "stryker run --logLevel error",
 		"test": "node ./test/test.mjs"
 	},

packages/base-cli/stryker.conf.json

@@ -7,9 +7,9 @@
 	"coverageAnalysis": "perTest",
 	"tempDirName": "../../.stryker-tmp",
 	"commandRunner": {
-		"command": "npm run test"
+		"command": "node ./test/test.mjs"
 	},
-	"buildCommand": "npm run build",
+	"buildCommand": "tsc",
 	"thresholds": {
 		"high": 100,
 		"low": 100,

packages/cascade-layer-name-parser/package.json

@@ -43,16 +43,11 @@
 		"@csstools/css-tokenizer": "^2.0.0"
 	},
 	"scripts": {
-		"prebuild": "npm run clean",
 		"build": "rollup -c ../../rollup/default.mjs",
-		"clean": "node -e \"fs.rmSync('./dist', { recursive: true, force: true }); fs.mkdirSync('./dist');\"",
-		"lint": "npm run lint:eslint && npm run lint:package-json",
-		"lint:eslint": "eslint ./src --ext .js --ext .ts --ext .mjs --no-error-on-unmatched-pattern",
-		"lint:package-json": "node ../../.github/bin/format-package-json.mjs",
-		"prepublishOnly": "npm run clean && npm run build && npm run test",
+		"lint": "node ../../.github/bin/format-package-json.mjs",
+		"prepublishOnly": "npm run build && npm run test",
 		"stryker": "stryker run --logLevel error",
-		"test": "node ./test/test.mjs",
-		"test:exports": "node ./test/_import.mjs && node ./test/_require.cjs",
+		"test": "node ./test/test.mjs && node ./test/_import.mjs && node ./test/_require.cjs",
 		"test:rewrite-expects": "REWRITE_EXPECTS=true node ./test/test.mjs"
 	},
 	"homepage": "https://github.com/csstools/postcss-plugins/tree/main/packages/cascade-layer-name-parser#readme",

packages/cascade-layer-name-parser/stryker.conf.json

@@ -3,12 +3,12 @@
 	"mutate": [
 		"src/**/*.ts"
 	],
-	"buildCommand": "npm run build",
+	"buildCommand": "rollup -c ../../rollup/default.mjs",
 	"testRunner": "command",
 	"coverageAnalysis": "perTest",
 	"tempDirName": "../../.stryker-tmp",
 	"commandRunner": {
-		"command": "npm run test"
+		"command": "node ./test/test.mjs"
 	},
 	"thresholds": {
 		"high": 100,