[jss] Update TS types #973
Conversation
|
I can't really review it, lets wait for @appsforartists |
|
I'm on vacation until February, and probably won't have much time for reviewing in the mean time. "This aligns the types more with @types/jss and adds a few features which were missing before." Can you split this into two PRs - one that imports |
|
Lets add changelog and move forward with this, we can always fix things retrospectively since we are in alpha |
|
I'm back from vacation now. I still don't understand why this isn't just an importing of Can we please import that package, and then you can make whatever changes you see fit? There's no good reason to start from scratch. |
… update-jss-types * jss-plugin-rule-value-function/fix-process-styles: (35 commits) Add formatting TS files Update typings Use types jss definitions Fix TS type definitions (#1030) v10.0.0-alpha.10 Update publish scripts (#1027) [docs] Update SSR setup with react-jss (#1018) temporarily remove the link to the docs, we need perma links instead #1006 [jss] Update SheetsManager (#1019) warn consumers if themed styles are misused. fix #1005 (#1006) Added TypeScript Usage documentation for React JSS (#1009) [react-jss] Export the context as __Context from react-jss (#1014) [jss-plugin-camel-case] Support css vars better (#1017) [docs] Add badges to readmes (#1016) Revert "Add tests for css variables in camel case plugins" Revert "Fix css variables being hyphenated" Revert "Run prettier" Run prettier Fix css variables being hyphenated Add tests for css variables in camel case plugins ... # Conflicts: # packages/jss/src/index.d.ts
|
I have a commit now which replaces the styles, and then I made the required changes on top of that. |
|
@HenriBeck did you port all types from the |
|
Yeah, most of them. |
packages/jss/src/index.d.ts
Outdated
| // Sebastian Silbermann <https://github.com/eps1lon> | ||
| // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped | ||
| // TypeScript Version: 2.3 | ||
| export type Style = object; |
There was a problem hiding this comment.
Without importing css from @types/css, you're losing type safety on Style. Can we merge this file too?
There was a problem hiding this comment.
Well, the file only guaranteed partial type safety on Style and a few things are missing. Also with our plugin API currently, it is really hard to type those things. So, for now, I would like to hold off on typing Style.
There is an open issue about adding types to Style: #806
|
|
||
| export type Styles<Name extends string = any> = Record<Name, Style>; | ||
| export type Classes<Name extends string = any> = Record<Name, string>; | ||
| export type JssValue = |
There was a problem hiding this comment.
If you merge in css.d.ts, you probably don't need this type alias (as you can use the correct type for each property).
|
@HenriBeck no changelog entry? |
* Updated jss types * Fix react-jss types * Use types jss definitions * Update typings * Add formatting TS files * Fix Style typescript definition * Add some tests for jss type definitions * Fix exports
What would you like to add/fix?
This aligns the types more with
@types/jssand adds a few features which were missing before.Corresponding issue (if exists): #964