v4: issue with @types/jss #14608

VincentLanglet · 2019-02-21T09:21:36Z

I have the error when I update to v4 for core and styles packages.

node_modules/@material-ui/core/styles/createGenerateClassName.d.ts:1:10 - error TS2305: Module '"../../../../../../../../../Users/vlanglet/Project/cloud/front/node_modules/jss/src"' has no exported member 'GenerateClassName'.

1 import { GenerateClassName } from 'jss';
           ~~~~~~~~~~~~~~~~~

node_modules/@material-ui/core/styles/jssPreset.d.ts:1:10 - error TS2724: Module '"../../../../../../../../../Users/vlanglet/Project/cloud/front/node_modules/jss/src"' has no exported member 'JSSOptions'. Did you mean 'JssOptions'?

1 import { JSSOptions } from 'jss';
           ~~~~~~~~~~

node_modules/@material-ui/core/styles/withStyles.d.ts:32:15 - error TS2694: Namespace '"/Users/vlanglet/Project/cloud/front/node_modules/jss/src/index"' has no exported member 'CreateStyleSheetOptions'.

32   extends JSS.CreateStyleSheetOptions<ClassKey> {

Expected Behavior 🤔

No error

Current Behavior 😯

node_modules/@material-ui/core/styles/createGenerateClassName.d.ts:1:10 - error TS2305: Module '"../../../../../../../../../Users/vlanglet/Project/cloud/front/node_modules/jss/src"' has no exported member 'GenerateClassName'.

1 import { GenerateClassName } from 'jss';
           ~~~~~~~~~~~~~~~~~

node_modules/@material-ui/core/styles/jssPreset.d.ts:1:10 - error TS2724: Module '"../../../../../../../../../Users/vlanglet/Project/cloud/front/node_modules/jss/src"' has no exported member 'JSSOptions'. Did you mean 'JssOptions'?

1 import { JSSOptions } from 'jss';
           ~~~~~~~~~~

node_modules/@material-ui/core/styles/withStyles.d.ts:32:15 - error TS2694: Namespace '"/Users/vlanglet/Project/cloud/front/node_modules/jss/src/index"' has no exported member 'CreateStyleSheetOptions'.

32   extends JSS.CreateStyleSheetOptions<ClassKey> {

Context 🔦

=> Found "[email protected]"
info Reasons this module exists
   - "@material-ui#styles" depends on it
   - Hoisted from "@material-ui#styles#jss"
info Disk size without dependencies: "544KB"
info Disk size with unique dependencies: "1.21MB"
info Disk size with transitive dependencies: "1.25MB"
info Number of shared dependencies: 4
=> Found "@material-ui/core#[email protected]"
info This module exists because "@material-ui#core" depends on it.
info Disk size without dependencies: "684KB"
info Disk size with unique dependencies: "824KB"
info Disk size with transitive dependencies: "884KB"
info Number of shared dependencies: 5

Your Environment 🌎

@material-ui/core@^4.0.0-alpha.1 and @material-ui/style@^4.0.0-alpha.1

The text was updated successfully, but these errors were encountered:

eps1lon · 2019-02-21T09:25:48Z

Duplicate of #14297

VincentLanglet · 2019-02-21T09:51:39Z

@eps1lon I didn't found this issue (#14297)

But, the issue is closed and I don't consider a good fix, a solution like

"postinstall": "mkdir -p node_modules/@material-ui/core/node_modules/@types/jss && cp -r node_modules/@types/jss node_modules/@material-ui/core/node_modules/@types"

You said

Since we started working on v4 I think that working on this issue is not very productive. Once we release v4 we should use a single styling solution.

But now, it's happening on v4, so I think we should work on it.

Can't @material-ui/core and @material-ui/styles use the same version of jss ?

eps1lon · 2019-02-21T10:04:14Z

@VincentLanglet The current v4 release is not final. As I said that issue should be gone once v4 is stable.

I agree that this solution is not optimal but we can't do anything beyond that. I think I explained it in depth why this is happening and why we can't control this behavior.

Can't @material-ui/core and @material-ui/styles use the same version of jss ?

The core won't have a dependency on jss anymore. We can't upgrade that dependency to jss@10 in @material-ui/core@3 because that would be a breaking change.

oliviertassinari · 2019-02-21T10:18:18Z

I believe the root of the issue is with the conflict between JSS v9 and JSS v10. I'm killing JSS v9 in #14560. It should help. I want to release the change in v4.0.0-alpha.2.

VincentLanglet · 2019-02-21T10:19:21Z

@eps1lon Ok
I didn't know @material-ui/core@4 wont have a dependency on jsssince the@material-ui/core@4-beta` still had one.

FYI, jss package is working on improving the typing cssinjs/jss#973
It may help

Edit : @oliviertassinari Great ! I think it'll fix everything indeed

VincentLanglet · 2019-03-05T15:36:49Z

Using patch-package (or making a PR) is a solution with :

node_modules/@material-ui/core/styles/createGenerateClassName.d.ts

-import { GenerateClassName } from 'jss';
+import { GenerateId } from 'jss';
 
...
 
-export default function createGenerateClassName(options?: GenerateClassNameOptions): GenerateClassName;
+export default function createGenerateClassName(options?: GenerateClassNameOptions): GenerateId;

node_modules/@material-ui/core/styles/jssPreset.d.ts

-import { JSSOptions } from 'jss';
+import { JssOptions } from 'jss';
 
-export default function jssPreset(): JSSOptions;
+export default function jssPreset(): JssOptions;

node_modules/@material-ui/core/styles/withStyles.d.ts

 export interface WithStylesOptions<ClassKey extends string = string>
-  extends JSS.CreateStyleSheetOptions<ClassKey> {
+  extends JSS.StyleSheetFactoryOptions {

VincentLanglet · 2019-03-11T16:44:55Z

@oliviertassinari I saw you merged your PR. Good job !

There was still one thing to do in order to stop using the @types/jss library.
It's here: #14852

oliviertassinari · 2019-03-11T22:17:58Z

@types/jss is gone, one less dependency :)

bouncydragon · 2019-03-20T09:30:46Z

@oliviertassinari the issue still exist, here is my package.json

"dependencies": { "@material-ui/core": "^3.9.2", "@material-ui/styles": "^3.0.0-alpha.10", "@types/react-loadable": "^5.5.0", "@types/react-router-dom": "^4.3.1", "prettier": "^1.16.4", "react": "^16.8.4", "react-dom": "^16.8.4", "react-loadable": "^5.5.0", "react-router-dom": "^5.0.0", "react-scripts-ts": "3.1.0" }
"devDependencies": { "@types/jest": "^24.0.11", "@types/node": "^11.11.3", "@types/react": "^16.8.8", "@types/react-dom": "^16.8.2", "eslint": "5.3.0", "eslint-config-airbnb-base": "13.1.0", "eslint-plugin-import": "^2.14.0", "typescript": "^3.3.3333" }

eps1lon · 2019-03-20T09:38:07Z

"dependencies": { "@material-ui/core": "^3.9.2", "@material-ui/styles": "^3.0.0-alpha.10"

@bouncydragon The issue is not fixed for older versions. Try @material-ui/core@^4.0.0-alpha.4 and @material-ui/styles@^4.0.0-alpha.4

bouncydragon · 2019-03-20T12:36:19Z

@eps1lon will there be any issues while developing a project using material ui in alpha?

eps1lon · 2019-03-20T12:43:19Z

@eps1lon will there be any issues while developing a project using material ui in alpha?

I can't make that promise for any version. You were already using an alpha (@material-ui/styles) so it seems you're ok with handling some rough edges that we're in the process of polishing.

bouncydragon · 2019-03-20T12:48:02Z

@eps1lon will there be any timeframe for the stable release of the alpha version?

oliviertassinari · 2019-03-20T15:34:48Z

@bouncydragon I hope we can release it within a month.

VincentLanglet mentioned this issue Feb 21, 2019

v3.8.2 issue with @types/jss #14040

Closed

2 tasks

eps1lon marked this as a duplicate of #14297 Feb 21, 2019

eps1lon added duplicate This issue or pull request already exists typescript labels Feb 21, 2019

oliviertassinari removed duplicate This issue or pull request already exists labels Feb 22, 2019

VincentLanglet mentioned this issue Mar 11, 2019

[core] Stop using @types/jss #14852

Merged

1 task

oliviertassinari closed this as completed in #14852 Mar 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v4: issue with @types/jss #14608

v4: issue with @types/jss #14608

VincentLanglet commented Feb 21, 2019

eps1lon commented Feb 21, 2019

VincentLanglet commented Feb 21, 2019 •

edited

Loading

eps1lon commented Feb 21, 2019

oliviertassinari commented Feb 21, 2019 •

edited

Loading

VincentLanglet commented Feb 21, 2019 •

edited

Loading

VincentLanglet commented Mar 5, 2019

VincentLanglet commented Mar 11, 2019

oliviertassinari commented Mar 11, 2019 •

edited

Loading

bouncydragon commented Mar 20, 2019 •

edited

Loading

eps1lon commented Mar 20, 2019

bouncydragon commented Mar 20, 2019

eps1lon commented Mar 20, 2019

bouncydragon commented Mar 20, 2019

oliviertassinari commented Mar 20, 2019

v4: issue with @types/jss #14608

v4: issue with @types/jss #14608

Comments

VincentLanglet commented Feb 21, 2019

Expected Behavior 🤔

Current Behavior 😯

Context 🔦

Your Environment 🌎

eps1lon commented Feb 21, 2019

VincentLanglet commented Feb 21, 2019 • edited Loading

eps1lon commented Feb 21, 2019

oliviertassinari commented Feb 21, 2019 • edited Loading

VincentLanglet commented Feb 21, 2019 • edited Loading

VincentLanglet commented Mar 5, 2019

VincentLanglet commented Mar 11, 2019

oliviertassinari commented Mar 11, 2019 • edited Loading

bouncydragon commented Mar 20, 2019 • edited Loading

eps1lon commented Mar 20, 2019

bouncydragon commented Mar 20, 2019

eps1lon commented Mar 20, 2019

bouncydragon commented Mar 20, 2019

oliviertassinari commented Mar 20, 2019

VincentLanglet commented Feb 21, 2019 •

edited

Loading

oliviertassinari commented Feb 21, 2019 •

edited

Loading

VincentLanglet commented Feb 21, 2019 •

edited

Loading

oliviertassinari commented Mar 11, 2019 •

edited

Loading

bouncydragon commented Mar 20, 2019 •

edited

Loading