Fix building on FreeBSD #2395
Closed
Fix building on FreeBSD #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes owncloud/ocis#1217 * Extracted common error methods to `errtypes` package * Fixed type error on Bavail ( https://golang.org/src/syscall/ztypes_freebsd_arm64.go#L125 ) * Alias ENODATA to ENOATTR How to test this on Linux: ``` export GOOS=freebsd make ```
wkloucek
requested review from
glpatcern,
ishank011,
labkode and
a team
as code owners
|
@wkloucek the issue is that with the go-prompt update, taking user input doesn't work, at least on mac systems. https://github.com/cs3org/reva/blob/master/cmd/reva/login.go#L99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased version of #1499, closes #1499