Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] OCIS not building on FreeBSD #1217

Closed
srcr opened this issue Jan 15, 2021 · 4 comments
Closed

[build] OCIS not building on FreeBSD #1217

srcr opened this issue Jan 15, 2021 · 4 comments

Comments

@srcr
Copy link

srcr commented Jan 15, 2021

OCIS is not building on FreeBSD as you can read below look like syscall.ENODATA is not defined in go on FreeBSD

peter@something:/d/t/b/ocis/ocis $ gmake build
go build -v -tags '' -ldflags '-s -w -X "github.com/owncloud/ocis/ocis/pkg/version.String=48ba063f" -X "github.com/owncloud/ocis/ocis/pkg/version.Date=20210115"' -o bin/ocis ./cmd/ocis
github.com/cs3org/reva/pkg/storage/fs/ocis
github.com/cs3org/reva/pkg/storage/fs/owncloud
# github.com/cs3org/reva/pkg/storage/fs/ocis
../../golang/pkg/mod/github.com/cs3org/[email protected]/pkg/storage/fs/ocis/permissions.go:260:19: undefined: syscall.ENODATA
# github.com/cs3org/reva/pkg/storage/fs/owncloud
../../golang/pkg/mod/github.com/cs3org/[email protected]/pkg/storage/fs/owncloud/owncloud.go:961:19: undefined: syscall.ENODATA
gmake: *** [Makefile:114: bin/ocis] Error 2

peter@something:/d/t/b/ocis/ocis $ uname -a
FreeBSD something 12.1-RELEASE-p10 FreeBSD 12.1-RELEASE-p10 GENERIC  amd64
@refs refs added the Category:Technical Technical ehancements label Jan 18, 2021
@refs
Copy link
Member

refs commented Jan 18, 2021

sounds like we'd need to support a build tag for FreeBSD. There's language support for syscall on FreeBSD already so changes should be trivial 👍 Thanks for opening an issue!

zaynetro added a commit to zaynetro/reva that referenced this issue Mar 20, 2021
Closes owncloud/ocis#1217

* Extracted common error methods to `errtypes` package
* Fixed type error on Bavail ( https://golang.org/src/syscall/ztypes_freebsd_arm64.go#L125 )
* Alias ENODATA to ENOATTR

How to test this on Linux:

```
export GOOS=freebsd
make
```
@settings settings bot removed the p3-medium label Apr 7, 2021
zaynetro added a commit to zaynetro/reva that referenced this issue Apr 12, 2021
Closes owncloud/ocis#1217

* Extracted common error methods to `errtypes` package
* Fixed type error on Bavail ( https://golang.org/src/syscall/ztypes_freebsd_arm64.go#L125 )
* Alias ENODATA to ENOATTR

How to test this on Linux:

```
export GOOS=freebsd
make
```
@stale
Copy link

stale bot commented Jun 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Jun 6, 2021
@refs refs added the Type:Bug label Jun 11, 2021
@stale stale bot removed the Status:Stale label Jun 11, 2021
@refs refs removed the Type:Bug label Jun 11, 2021
@refs refs changed the title OCIS not building on FreeBSD [build] OCIS not building on FreeBSD Jun 11, 2021
@stale
Copy link

stale bot commented Aug 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Aug 10, 2021
zaynetro added a commit to zaynetro/reva that referenced this issue Aug 19, 2021
Closes owncloud/ocis#1217

* Extracted common error methods to `errtypes` package
* Fixed type error on Bavail ( https://golang.org/src/syscall/ztypes_freebsd_arm64.go#L125 )
* Alias ENODATA to ENOATTR

How to test this on Linux:

```
export GOOS=freebsd
make
```
@stale stale bot closed this as completed Aug 20, 2021
@stale stale bot removed the Status:Stale label Aug 24, 2021
@micbar
Copy link
Contributor

micbar commented Jun 5, 2024

This issue is outdated. Please re open if still needed.

@micbar micbar closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants