This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Revert some code about file picker. #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be merged on 2171. BUG=418816 [email protected] [email protected] Review URL: https://codereview.chromium.org/616713002 Cr-Commit-Position: refs/heads/master@{#297319} (cherry picked from commit 20d9928) Review URL: https://codereview.chromium.org/618543002 Cr-Commit-Position: refs/branch-heads/2171@{#4} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
H264 is useful for some users that cannot use VP8. BUG=chromium:414567 TEST=run apprtc and ensure it still uses VP8 where available Review URL: https://codereview.chromium.org/603263004 [email protected] Cr-Commit-Position: refs/heads/master@{#297070} (cherry picked from commit 172379d) Review URL: https://codereview.chromium.org/619783002 Cr-Commit-Position: refs/branch-heads/2171@{#5} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
BUG=418859 Review URL: https://codereview.chromium.org/615803002 Cr-Commit-Position: refs/heads/master@{#297470} (cherry picked from commit dbcbacd) [email protected] Review URL: https://codereview.chromium.org/618173002 Cr-Commit-Position: refs/branch-heads/2171@{#8} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
Merge to M39, branch 2171 ----------------Original CL Description----------------------- (This is a stopgap until the zipping mentioned in the bug can happen.) Original Review URL: https://codereview.chromium.org/612143002 Original Cr-Commit-Position: refs/heads/master@{#297266} BUG=33920 TEST=<input type=file multiple />, ensure packages can't be selected [email protected] Review URL: https://codereview.chromium.org/616993003 Cr-Commit-Position: refs/branch-heads/2171@{#9} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…e changes. Previously DirectoryModel#partialUpdate ignores changes if the function is called multiple times during the previous request is being procecced. BUG=417163 TEST=Repo steps of the bug. [email protected] Review URL: https://codereview.chromium.org/611193002 Cr-Commit-Position: refs/heads/master@{#297381} (cherry picked from commit 8ad2b71) Review URL: https://codereview.chromium.org/613413003 Cr-Commit-Position: refs/branch-heads/2171@{#10} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
The type causes an exception and it prevent the app from running progressCenter.removePanel. So the disposed ProgressCenterPanel remains in the ProgressCenter and it causes another bug. BUG=418517 TEST=repo steps of the bug. [email protected] Review URL: https://codereview.chromium.org/618563002 Cr-Commit-Position: refs/heads/master@{#297353} (cherry picked from commit 26acebd) Review URL: https://codereview.chromium.org/618193002 Cr-Commit-Position: refs/branch-heads/2171@{#12} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
Pure HTML/CSS changes. No tests affected. BUG=413337,416228 Review URL: https://codereview.chromium.org/612823005 (cherry picked from commit 09cf097) Cr-Original-Commit-Position: refs/heads/master@{#297270} Cr-Commit-Position: refs/branch-heads/2171@{#14} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…in from JS Previously we were using the plugin context when converting objects during calls into the plugin from JS. As decided previously in https://codereview.chromium.org/555583003/ we should always use the caller's context in these circumstances. This CL also separates the checks in PepperPluginInstanceImpl::GetContext to help diagnose crbug.com/416311. BUG=416311 Review URL: https://codereview.chromium.org/588083002 Cr-Commit-Position: refs/heads/master@{#297136} (cherry picked from commit 816f98b) Review URL: https://codereview.chromium.org/614223004 Cr-Commit-Position: refs/branch-heads/2171@{#16} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
Blocking renderer->plugin messages can be interrupted by any message from the plugin->renderer (even async ones). So while handline a blocking message, such as HandleInputEvent or HandleBlockingMessage, it's currently possible to re-enter JavaScript. This patch makes that impossible by queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage while any renderer->plugin sync message is on the stack. BUG=384528 TBR=raymes Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506 Cr-Commit-Position: refs/heads/master@{#296311} Committed: https://crrev.com/3fe4ceee750b2cd130bd402de3d371d8518c3eba Cr-Commit-Position: refs/heads/master@{#296807} Review URL: https://codereview.chromium.org/589213003 Cr-Commit-Position: refs/heads/master@{#297308} (cherry picked from commit 6b328f3) Review URL: https://codereview.chromium.org/615393005 Cr-Commit-Position: refs/branch-heads/2171@{#17} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
BUG=418190 TBR=kuan Review URL: https://codereview.chromium.org/607013003 Cr-Commit-Position: refs/heads/master@{#297100} (cherry picked from commit 69231d0) Review URL: https://codereview.chromium.org/621743006 Cr-Commit-Position: refs/branch-heads/2171@{#18} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
BUG=401365 TBR=mattm Review URL: https://codereview.chromium.org/515813002 Cr-Commit-Position: refs/heads/master@{#297061} (cherry picked from commit 80daaf7) Review URL: https://codereview.chromium.org/621833005 Cr-Commit-Position: refs/branch-heads/2171@{#20} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
BUG=401365 TBR=davidben Review URL: https://codereview.chromium.org/509273002 Cr-Commit-Position: refs/heads/master@{#297307} (cherry picked from commit b92e6f5) Review URL: https://codereview.chromium.org/614353006 Cr-Commit-Position: refs/branch-heads/2171@{#21} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
BUG=401365 TBR=davidben Review URL: https://codereview.chromium.org/508823009 Cr-Commit-Position: refs/heads/master@{#297331} (cherry picked from commit 4f80127) Review URL: https://codereview.chromium.org/618063004 Cr-Commit-Position: refs/branch-heads/2171@{#22} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
Previusly JavaScript send a request to create a cache file before mounting zip file, but the code was recently removed. This CL adds lines to create a cache to the API for mouting a zip file. BUG=419285 TEST=repro steps on the bug TBR=kinaba Review URL: https://codereview.chromium.org/622513002 Cr-Commit-Position: refs/heads/master@{#297622} (cherry picked from commit cf84106) Review URL: https://codereview.chromium.org/626463002 Cr-Commit-Position: refs/branch-heads/2171@{#23} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
VideoEncodeAccelerator::GetSupportedProfiles now runs in GPU process because the profiles were added to GPUInfo. Add kEnableWebRtcHWVp8Encoding to GPU process to fix the missing encode profile. BUG=418762 TEST=Run apprtc loopback and check the histogram. [email protected] Review URL: https://codereview.chromium.org/618633002 Cr-Commit-Position: refs/heads/master@{#297445} (cherry picked from commit ebd596b) Review URL: https://codereview.chromium.org/620963002 Cr-Commit-Position: refs/branch-heads/2171@{#24} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
On startup, VaapiWrapper::GetSupportedEncodeProfiles is called to query HW encoder capabilities to fill GpuInfo with. On VM test however there is no libva present, so we error out, but also attempt to report an error to UMA, which blocks and the GPU process gets killed by the GPU watchdog. We don't need to report failures on GetSupportedEncodeProfiles however, as we will report them later when we attempt to encode anyway. BUG=402182 TEST=test lumpy under kvm and check chrome is not blocked by GetSupportedEncodeProfiles [email protected] Review URL: https://codereview.chromium.org/613223002 Cr-Commit-Position: refs/heads/master@{#297564} (cherry picked from commit 4505d0f) Review URL: https://codereview.chromium.org/623613005 Cr-Commit-Position: refs/branch-heads/2171@{#25} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…d during OOBE" This reverts commit f406302. BUG=365354 [email protected] Review URL: https://codereview.chromium.org/614223006 Cr-Commit-Position: refs/branch-heads/2171@{#26} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
> > BUG=418214 > > Review URL: https://codereview.chromium.org/609983002 > > Cr-Commit-Position: refs/heads/master@{#297094} > (cherry picked from commit 2a49d59) [email protected] Review URL: https://codereview.chromium.org/624623002 Cr-Commit-Position: refs/branch-heads/2171@{#27} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…elated. Previously we were only doing this if the --new-avatar-menu was flipped. This is a two-part CL. This CL removes the usages of the strings, but not the strings themselves, since that involves some renaming and I'd like to merge this to M39. The CL that actually removes the unused strings is: https://codereview.chromium.org/603023004/ XIB changes: use a different string ID for the profiles menu in the menu bar. BUG=405988 [email protected] Review URL: https://codereview.chromium.org/611033002 Cr-Commit-Position: refs/heads/master@{#297222} (cherry picked from commit 7252caf) Review URL: https://codereview.chromium.org/614103009 Cr-Commit-Position: refs/branch-heads/2171@{#28} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
The strings stopped being used in https://codereview.chromium.org/611033002/ XIB changes: use a different string ID for the profiles menu in the menu bar. BUG=405988 [email protected] Review URL: https://codereview.chromium.org/603023004 Cr-Commit-Position: refs/heads/master@{#297422} Review URL: https://codereview.chromium.org/625643002 Cr-Commit-Position: refs/branch-heads/2171@{#29} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…upload ACCOUNT_CREATION_PASSWORD Update test to catch the problem. Previous test mocked out bad behavior. BUG=419228 [email protected] Review URL: https://codereview.chromium.org/614313002 Cr-Commit-Position: refs/heads/master@{#297580} (cherry picked from commit 44c5e4e) Review URL: https://codereview.chromium.org/624643002 Cr-Commit-Position: refs/branch-heads/2171@{#30} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
5d9bef8 to
18a33ff
Compare
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
Add CHROMIUM_ycbcr_422_image extension. Add an extension that provides a method for GL to process images that are defined in '2vuy' video format. GL_YCRCR_422_CHROMIUM <internalformat> as been added and it is an accepted value when creating an image if the extension is supported. This extension maps to GL_APPLE_ycbcr_422 and will allow us to determine if we can use IOSurfaces with that format. BUG=524582 Review URL: https://codereview.chromium.org/1305153005 Cr-Commit-Position: refs/heads/master@{#345693} (cherry picked from commit a93c581) Review URL: https://codereview.chromium.org/1319783009 . Cr-Commit-Position: refs/branch-heads/2490@{#200} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
830d9f6 to
5ad5a18
Compare
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
For certain XKB key mapping, e.g. colemak, the modifier key is mapped to non-modifier, e.g. Search (identical to WIN key) maps to backspace. In such case, event rewriter can rewrite the key back to modifier key successfully but fails to rewrite the modifier flag to the later keys, because the later keys has no modifier flag, so nothing to rewrite. This cl leverages the "latches" flag state in event rewriter to make the remapped modifier flag can be remembered and apply to the later keys. BUG=215923 TEST=Activates colemak keyboard, press Search+U (which is Search+L in colemak key mapping), the screen can be locked. Review URL: https://codereview.chromium.org/1473773004 Cr-Commit-Position: refs/heads/master@{#362088} (cherry picked from commit 27aa4f7) Review URL: https://codereview.chromium.org/1486423004 . Cr-Commit-Position: refs/branch-heads/2564@{#200} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
1072537 to
512d729
Compare
rakuco
force-pushed
the
master
branch
2 times, most recently
from
0f31e18 to
3da217c
Compare
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
BUG=582614 (cherry picked from commit 18001efee129dafec27acd52dfa1ed273385250c) Review URL: https://codereview.chromium.org/1652433003 . Cr-Commit-Position: refs/branch-heads/2623@{#200} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Prior to this patch when adding a view we could call into OnNativeThemeChanged() before ensuring the layer tree and view tree are in sync. This is problematic as its entirely possible for client code to trigger trying to resync the layer tree and view tree, and since we assume the two are already in sync we get crashes. As part of this I'm moving syncing the layer trees out of ViewHierarchyChangedImpl() into the call sites so we can ensure the layer tree and view tree are in sync before calling any client code. BUG=590696 TEST=covered by test [email protected] Review URL: https://codereview.chromium.org/1768533003 Cr-Commit-Position: refs/heads/master@{#379620} (cherry picked from commit 16f0d34) Review URL: https://codereview.chromium.org/1783353007 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#200} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#200}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
[email protected] Change-Id: I80dbb2d8b1e58adf7ef869055be420c9fb7791f7 Reviewed-on: https://chromium-review.googlesource.com/664982 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#200} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is to revert some code about file picker.
If the app client does not declare content provider and file path
of image was used, file picker will not work.
Related list of Chromium CLs:
https://codereview.chromium.org/489053003
https://codereview.chromium.org/591253002
BUG=XWALK-2631, XWALK-2717