Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): lint #88

Merged
merged 4 commits into from
Apr 29, 2022
Merged

fix(ci): lint #88

merged 4 commits into from
Apr 29, 2022

Conversation

Duologic
Copy link
Member

Description of your changes

The lint CI job was consistently failing, this PR pulls in changes from upbound/build and
crossplane/provider-template to mitigate that failure.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Tested fix for reproducible failure on #87

@Duologic Duologic mentioned this pull request Apr 29, 2022
@Duologic Duologic requested review from srueg and jdotw April 29, 2022 08:29
@Duologic Duologic mentioned this pull request Apr 29, 2022
2 tasks
Signed-off-by: Duologic <[email protected]>
Copy link
Collaborator

@jdotw jdotw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work man, thank you!

@Duologic Duologic merged commit ca1b76f into master Apr 29, 2022
@Duologic Duologic deleted the duologic/fix_lint branch April 29, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants