-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial pass at adding tls support to mysql #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests seem to fail, can you have a look? Note that the golangci-lint version might differ:
provider-sql/.github/workflows/ci.yml
Lines 13 to 15 in 2f501aa
GO_VERSION: '1.17' | |
GOLANGCI_VERSION: 'v1.31' | |
DOCKER_BUILDX_VERSION: 'v0.7.1' |
I'm trying to get these tests to run in my fork's Github Actions so I can debug further. Same as Alex in #84 mentions, I'm not sure what to do to test locally. Maybe a quick guide on how to run them locally? |
|
I figured it out I think. Added some docs to the README to help future contributors who might not know what they are doing, like me. 😁 |
I bumped Also, the CI pipeline has golang 1.17 pinned, but the |
I had a look at bumping the golangci-lint before but it is also set in the build tools. I think it is best to keep those aligned. https://github.com/upbound/build/blob/master/makelib/golang.mk#L99 If we want to bump versions, I'd suggest doing that in a separate PR so we can also adress the versions in the upstream repo. |
@Duologic I reverted the |
1ba9d0e
to
ffcd036
Compare
I'm attempting to fix the lint CI job in #88 |
#88 is merged, do you mind rebasing? |
@Duologic all the tests passed in my fork |
5378a98
to
df49141
Compare
I think we need to revert the change on the build submodule and follow master. |
Yeah I tried to debug it yesterday but I wasn't getting anywhere. So change |
@MattMencel I managed to get it working in #91, you can cherry-pick my commits if you like. |
Signed-off-by: Matt Mencel <[email protected]>
Signed-off-by: Matt Mencel <[email protected]>
Signed-off-by: Matt Mencel <[email protected]>
Signed-off-by: Matt Mencel <[email protected]>
Signed-off-by: Matt Mencel <[email protected]>
Signed-off-by: Matt Mencel <[email protected]>
Signed-off-by: Duologic <[email protected]>
Signed-off-by: Duologic <[email protected]>
@Duologic cherry-picked |
Description of your changes
Enables
tls
for MySQL connections. Setspreferred
as the default which will fall back to non-tls if unsupported by the MySQL instance."Fixes #70":
"Fixes #81":
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
make reviewable