Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement AWS RDS DB ParameterGroups #630

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

Dkaykay
Copy link
Contributor

@Dkaykay Dkaykay commented Apr 14, 2021

Description of your changes

Added AWS RDS DB Parametergroups resources as described in
#567
by following the guidelines in https://github.com/crossplane/provider-aws/blob/master/CODE_GENERATION.md

I have:

  • [ x ] Read and followed Crossplane's [contribution process].
  • [ x ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • [ x ] Run make reviewable test
  • create resource by applying example claim
  • update resource by updating example claim
  • delete resource by deleting example claim

Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's been reviewed and approved here already #577

Thanks a lot @Dkaykay !!

@muvaf muvaf merged commit cbd5081 into crossplane-contrib:master Apr 14, 2021
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants