Add feature for RDS DB Parametergroups #577

Dkaykay · 2021-03-05T08:25:21Z

Description of your changes

Add rds/dbparametergroup resources as described in
#567
by following the guidelines in https://github.com/crossplane/provider-aws/blob/master/CODE_GENERATION.md

ToDo:
Add the possibility to pass in json / parameters that will be added/changed in the created DB parametergroup. It seems like these parameters cant be passed in at creation of the parametergroup. They need to be changed after it is created:
https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_ModifyDBParameterGroup.html

Signed-off-by: Denis Holschuh <[email protected]>

Signed-off-by: Dkaykay <[email protected]>

muvaf

Thanks @Dkaykay ! That's a pretty good start!

pkg/controller/rds/dbparametergroup/setup.go

pkg/controller/rds/dbparametergroup/zz_controller.go

muvaf · 2021-03-08T13:43:32Z

apis/rds/v1alpha1/zz_db_parameter_group.go

+	//
+	// This value is stored as a lowercase string.
+	// +kubebuilder:validation:Required
+	DBParameterGroupName *string `json:"dbParameterGroupName"`


We are using external name annotation for this field, so we should ignore it in generator-config.yaml like this. It needs to be ignored in all AWS calls in zz_controller.go, i.e. CreateDBParameterGroupInput.DBParameterGroupName etc.

You need to re-run the code generator so that this field is removed.

…t to generator-config.yaml Signed-off-by: Dkaykay <[email protected]>

…payload obj Signed-off-by: Dkaykay <[email protected]>

Signed-off-by: Dkaykay <[email protected]>

Dkaykay · 2021-03-15T13:45:31Z

@muvaf can you review, please? Implemented & tested basic functionalities for creating, updating and deleting RDS DB Parametergroups

muvaf

There are a few small things but I think it's pretty close to merge. Thanks a lot @Dkaykay !

apis/rds/v1alpha1/generator-config.yaml

examples/rds/dbparametergroup.yaml

pkg/controller/rds/dbparametergroup/setup.go

apis/rds/v1alpha1/custom_types.go

pkg/controller/rds/dbparametergroup/setup.go

Signed-off-by: Dkaykay <[email protected]>

… more robustness Signed-off-by: Dkaykay <[email protected]>

Signed-off-by: Dkaykay <[email protected]>

muvaf

LGTM! A few things:

ACK needs to run again to remove the DBParameterGroupName from CRD.
make reviewable should work.
Could you squash the commits?
Lastly, can you confirm given example YAML works? create, update, delete scenarios.

muvaf · 2021-04-09T19:27:57Z

apis/rds/v1alpha1/zz_db_parameter_group.go

+	//
+	// This value is stored as a lowercase string.
+	// +kubebuilder:validation:Required
+	DBParameterGroupName *string `json:"dbParameterGroupName"`


You need to re-run the code generator so that this field is removed.

muvaf · 2021-04-09T19:28:19Z

examples/rds/dbparametergroup.yaml

+spec:
+  forProvider:
+    region: eu-central-1
+    dbParameterGroupName: example-dbparametergroup


Suggested change

dbParameterGroupName: example-dbparametergroup

I added to generator-config.yaml:
- CreateDBParameterGroupInput.DBParameterGroupName
- DeleteDBParameterGroupInput.DBParameterGroupName
- ModifyDBParameterGroupInput.DBParameterGroupName
- DescribeDBParameterGroupInput.DBParameterGroupName

But the field is not getting removed when running the generator. What am i missing here @muvaf ?

Also, it seems that i am not authorized to squash & merge due to the branch being protected.

make reviewable test was green as well as create, update and delete scenarios.

You can squash your commits locally and then git push --force because you’re pushing to your own fork

examples/rds/dbparametergroup.yaml

pkg/controller/rds/dbparametergroup/setup.go

Signed-off-by: Dkaykay <[email protected]>

Signed-off-by: Dkaykay <[email protected]> fix: remove DBParameterGroupName chore: make example more generic

…ykay/provider-aws into feature/rds-dbparametergroup

Signed-off-by: Denis Holschuh <[email protected]>

…ykay/provider-aws into feature/rds-dbparametergroup

Signed-off-by: Dkaykay <[email protected]>

…ykay/provider-aws into feature/rds-dbparametergroup

Signed-off-by: Dkaykay <[email protected]>

…ykay/provider-aws into feature/rds-dbparametergroup

Dkaykay · 2021-04-14T11:12:45Z

closing PR and re-creating from non-broken branch

…4.56.0 Bump Terraform provider version to v4.56.0

dholeshu added 3 commits March 5, 2021 09:41

initial commit: add db parametergroup via code generation pipeline

1b97f70

Signed-off-by: Denis Holschuh <[email protected]>

feat: add example dbparamergroup crd yaml

f37ca2c

Signed-off-by: Denis Holschuh <[email protected]>

docs: add required comments for passing tests

8b8ae85

Signed-off-by: Denis Holschuh <[email protected]>

Dkaykay force-pushed the feature/rds-dbparametergroup branch from a110739 to 8b8ae85 Compare March 5, 2021 08:42

fix: generic example

4de48df

Signed-off-by: Denis Holschuh <[email protected]>

Dkaykay force-pushed the feature/rds-dbparametergroup branch from e90dbb5 to 4de48df Compare March 5, 2021 09:08

muvaf self-assigned this Mar 8, 2021

dholeshu added 2 commits March 8, 2021 12:45

feat(dbparametergroup): add externalname handling and readiness check

6354ba6

Signed-off-by: Dkaykay <[email protected]>

fix: linter issues

6d55b38

Signed-off-by: Dkaykay <[email protected]>

muvaf reviewed Mar 8, 2021

View reviewed changes

dholeshu added 10 commits March 8, 2021 14:53

feature: ignore external name annotation in all aws calls by adding i…

6bcf9f1

…t to generator-config.yaml Signed-off-by: Dkaykay <[email protected]>

fix: replace postCreate with preCreate and give external name to the …

64495fd

…payload obj Signed-off-by: Dkaykay <[email protected]>

feat: add CustomDBParameterGroupParameters in custom types

c92855d

Signed-off-by: Dkaykay <[email protected]>

feat: add parameters to example

d399742

Signed-off-by: Dkaykay <[email protected]>

feat: implement preUpdate function to write parameters to obj

a23d20f

Signed-off-by: Dkaykay <[email protected]>

feat: add CustomDBParameterGroupParameters in custom types

e19e4fd

Signed-off-by: Dkaykay <[email protected]>

feat: add more possible parameters

f331c60

Signed-off-by: Dkaykay <[email protected]>

feat: simplify example

e1cdc83

Signed-off-by: Dkaykay <[email protected]>

feat: implement isUpToDate function

e34c045

Signed-off-by: Dkaykay <[email protected]>

fix: linter problems

51733ac

Signed-off-by: Dkaykay <[email protected]>

Dkaykay marked this pull request as ready for review March 10, 2021 15:07

Dkaykay requested a review from muvaf March 12, 2021 09:03

Dkaykay changed the title ~~feature/rds-dbparametergroup~~ Add feature for RDS DB Parametergroups Mar 12, 2021

muvaf reviewed Apr 7, 2021

View reviewed changes

dholeshu added 3 commits April 8, 2021 08:38

fix: exclude DescribeDBParameterGroupInput in generator config

1a4b404

Signed-off-by: Dkaykay <[email protected]>

fix: exclude DescribeDBParameterGroupInput in generator config

959b0d1

Signed-off-by: Dkaykay <[email protected]>

fix: make example more generic

606c554

Signed-off-by: Dkaykay <[email protected]>

dholeshu added 8 commits April 8, 2021 08:58

feat: fill all rds.Parameter fields

b4306a2

Signed-off-by: Dkaykay <[email protected]>

fix: duplicated import & references

5ece16a

Signed-off-by: Dkaykay <[email protected]>

feat: iterate over all pages of DescribeDBParametersOutput

b717bfb

Signed-off-by: Dkaykay <[email protected]>

feat: fill all rds.Parameter fields, remove pointer dereferencing for…

9611416

… more robustness Signed-off-by: Dkaykay <[email protected]>

fix: compare only string values for isuptodate detection

220841a

Signed-off-by: Dkaykay <[email protected]>

fix: deepcopy

efb9724

Signed-off-by: Dkaykay <[email protected]>

fix: make comparison for isUpToDate more efficient

38c2477

Signed-off-by: Dkaykay <[email protected]>

chore: cleanup

e9c4315

Signed-off-by: Dkaykay <[email protected]>

Dkaykay requested a review from muvaf April 9, 2021 06:52

muvaf approved these changes Apr 9, 2021

View reviewed changes

dholeshu and others added 15 commits April 12, 2021 13:22

fix: import grouping

0202a36

Signed-off-by: Dkaykay <[email protected]>

feat: ignore DBParameterGroupName in generator-config.yaml

e7ea3bc

Signed-off-by: Dkaykay <[email protected]>

fix: remove DBParameterGroupName

ab60ead

chore: make example more generic

12a5435

feat: ignore DBParameterGroupName in generator-config.yaml

36dd16b

Signed-off-by: Dkaykay <[email protected]> fix: remove DBParameterGroupName chore: make example more generic

Merge branch 'feature/rds-dbparametergroup' of https://github.com/Dka…

087b128

…ykay/provider-aws into feature/rds-dbparametergroup

initial commit: add db parametergroup via code generation pipeline

4559458

Signed-off-by: Denis Holschuh <[email protected]>

Merge branch 'feature/rds-dbparametergroup' of https://github.com/Dka…

00d0dbd

…ykay/provider-aws into feature/rds-dbparametergroup

feat: finalize DBParameterGroup Implementation

ce4464b

Signed-off-by: Dkaykay <[email protected]>

feat: finalize DBParameterGroup Implementation

0e2e73a

Signed-off-by: Dkaykay <[email protected]>

Merge branch 'feature/rds-dbparametergroup' of https://github.com/Dka…

fab596d

…ykay/provider-aws into feature/rds-dbparametergroup

fix: remove unusued entries from generator-config.yaml

64ddbaf

Signed-off-by: Dkaykay <[email protected]>

feat: finalize DBParameterGroup Implementation

508a372

Signed-off-by: Dkaykay <[email protected]>

fix: remove unusued entries from generator-config.yaml

4b2da68

Signed-off-by: Dkaykay <[email protected]>

Merge branch 'feature/rds-dbparametergroup' of https://github.com/Dka…

dac5c63

…ykay/provider-aws into feature/rds-dbparametergroup

Dkaykay closed this Apr 14, 2021

Dkaykay reopened this Apr 14, 2021

Dkaykay closed this Apr 14, 2021

tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024

Merge pull request crossplane-contrib#577 from dverveiko/tf-provider-…

900526e

…4.56.0 Bump Terraform provider version to v4.56.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add feature for RDS DB Parametergroups #577

Add feature for RDS DB Parametergroups #577

Dkaykay commented Mar 5, 2021

muvaf left a comment

muvaf Mar 8, 2021

muvaf Apr 9, 2021

Dkaykay commented Mar 15, 2021 •

edited

Loading

muvaf left a comment

muvaf left a comment

muvaf Apr 9, 2021

muvaf Apr 9, 2021

Dkaykay Apr 12, 2021 •

edited

Loading

Dkaykay Apr 12, 2021

muvaf Apr 14, 2021

Dkaykay commented Apr 14, 2021

Add feature for RDS DB Parametergroups #577

Add feature for RDS DB Parametergroups #577

Conversation

Dkaykay commented Mar 5, 2021

Description of your changes

muvaf left a comment

Choose a reason for hiding this comment

muvaf Mar 8, 2021

Choose a reason for hiding this comment

muvaf Apr 9, 2021

Choose a reason for hiding this comment

Dkaykay commented Mar 15, 2021 • edited Loading

muvaf left a comment

Choose a reason for hiding this comment

muvaf left a comment

Choose a reason for hiding this comment

muvaf Apr 9, 2021

Choose a reason for hiding this comment

muvaf Apr 9, 2021

Choose a reason for hiding this comment

Dkaykay Apr 12, 2021 • edited Loading

Choose a reason for hiding this comment

Dkaykay Apr 12, 2021

Choose a reason for hiding this comment

muvaf Apr 14, 2021

Choose a reason for hiding this comment

Dkaykay commented Apr 14, 2021

Dkaykay commented Mar 15, 2021 •

edited

Loading

Dkaykay Apr 12, 2021 •

edited

Loading