Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for RDS DB Parametergroups #577

Closed
Closed
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
1b97f70
initial commit: add db parametergroup via code generation pipeline
dholeshu Mar 5, 2021
f37ca2c
feat: add example dbparamergroup crd yaml
dholeshu Mar 5, 2021
8b8ae85
docs: add required comments for passing tests
dholeshu Mar 5, 2021
4de48df
fix: generic example
dholeshu Mar 5, 2021
6354ba6
feat(dbparametergroup): add externalname handling and readiness check
dholeshu Mar 8, 2021
6d55b38
fix: linter issues
dholeshu Mar 8, 2021
6bcf9f1
feature: ignore external name annotation in all aws calls by adding i…
dholeshu Mar 8, 2021
64495fd
fix: replace postCreate with preCreate and give external name to the …
dholeshu Mar 8, 2021
c92855d
feat: add CustomDBParameterGroupParameters in custom types
dholeshu Mar 9, 2021
d399742
feat: add parameters to example
dholeshu Mar 9, 2021
a23d20f
feat: implement preUpdate function to write parameters to obj
dholeshu Mar 9, 2021
e19e4fd
feat: add CustomDBParameterGroupParameters in custom types
dholeshu Mar 9, 2021
f331c60
feat: add more possible parameters
dholeshu Mar 9, 2021
e1cdc83
feat: simplify example
dholeshu Mar 10, 2021
e34c045
feat: implement isUpToDate function
dholeshu Mar 10, 2021
51733ac
fix: linter problems
dholeshu Mar 10, 2021
1a4b404
fix: exclude DescribeDBParameterGroupInput in generator config
dholeshu Apr 8, 2021
959b0d1
fix: exclude DescribeDBParameterGroupInput in generator config
dholeshu Apr 8, 2021
606c554
fix: make example more generic
dholeshu Apr 8, 2021
90ec09e
chore: cosmetics
dholeshu Apr 8, 2021
9ada6ea
fix: make it easier to work with slices
dholeshu Apr 8, 2021
b4306a2
feat: fill all rds.Parameter fields
dholeshu Apr 8, 2021
5ece16a
fix: duplicated import & references
dholeshu Apr 8, 2021
b717bfb
feat: iterate over all pages of DescribeDBParametersOutput
dholeshu Apr 8, 2021
9611416
feat: fill all rds.Parameter fields, remove pointer dereferencing for…
dholeshu Apr 8, 2021
220841a
fix: compare only string values for isuptodate detection
dholeshu Apr 8, 2021
efb9724
fix: deepcopy
dholeshu Apr 8, 2021
38c2477
fix: make comparison for isUpToDate more efficient
dholeshu Apr 8, 2021
e9c4315
chore: cleanup
dholeshu Apr 8, 2021
0202a36
fix: import grouping
dholeshu Apr 12, 2021
e7ea3bc
feat: ignore DBParameterGroupName in generator-config.yaml
dholeshu Apr 13, 2021
ab60ead
fix: remove DBParameterGroupName
dholeshu Apr 14, 2021
12a5435
chore: make example more generic
dholeshu Apr 14, 2021
36dd16b
feat: ignore DBParameterGroupName in generator-config.yaml
dholeshu Apr 13, 2021
087b128
Merge branch 'feature/rds-dbparametergroup' of https://github.com/Dka…
Dkaykay Apr 14, 2021
4559458
initial commit: add db parametergroup via code generation pipeline
dholeshu Mar 5, 2021
00d0dbd
Merge branch 'feature/rds-dbparametergroup' of https://github.com/Dka…
Dkaykay Apr 14, 2021
ce4464b
feat: finalize DBParameterGroup Implementation
Dkaykay Apr 14, 2021
0e2e73a
feat: finalize DBParameterGroup Implementation
Dkaykay Apr 14, 2021
fab596d
Merge branch 'feature/rds-dbparametergroup' of https://github.com/Dka…
dholeshu Apr 14, 2021
64ddbaf
fix: remove unusued entries from generator-config.yaml
dholeshu Apr 14, 2021
508a372
feat: finalize DBParameterGroup Implementation
Dkaykay Apr 14, 2021
4b2da68
fix: remove unusued entries from generator-config.yaml
dholeshu Apr 14, 2021
dac5c63
Merge branch 'feature/rds-dbparametergroup' of https://github.com/Dka…
dholeshu Apr 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apis/rds/v1alpha1/custom_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ package v1alpha1

import xpv1 "github.com/crossplane/crossplane-runtime/apis/common/v1"

// CustomDBParameterGroupParameters are custom parameters for DBParameterGroup
type CustomDBParameterGroupParameters struct {
// A list of parameters to associate with this DB parameter group
// +optional
Parameters []Parameter `json:"parameters,omitempty"`
}

// CustomDBClusterParameters are custom parameters for DBCluster
type CustomDBClusterParameters struct {

Expand Down
5 changes: 4 additions & 1 deletion apis/rds/v1alpha1/generator-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,17 @@ ignore:
- CreateDBClusterInput.VpcSecurityGroupIds
- ModifyDBClusterInput.VpcSecurityGroupIds
- DBCluster.PendingModifiedValues
- CreateDBParameterGroupInput.DBParameterGroupName
Dkaykay marked this conversation as resolved.
Show resolved Hide resolved
- DeleteDBParameterGroupInput.DBParameterGroupName
- ModifyDBParameterGroupInput.DBParameterGroupName
- DescribeDBParameterGroupsInput.DBParameterGroupName
resource_names:
- DBClusterEndpoint
- CustomAvailabilityZone
- DBClusterParameterGroup
- DBClusterSnapshot
- DBInstance
- DBInstanceReadReplica
- DBParameterGroup
- DBProxy
- DBSecurityGroup
- DBSnapshot
Expand Down
118 changes: 118 additions & 0 deletions apis/rds/v1alpha1/zz_db_parameter_group.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading