fix(kafka): add clusterName because of api-changes

[haarchri]

Signed-off-by: Christopher Paul Haar [email protected]

Description of your changes

fix(kafka): add clusterName because of api-changes

Fixes #1612
replace: #1620

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

kubectl get managed

NAME                                      READY   SYNCED   EXTERNAL-NAME
cluster.kafka.aws.crossplane.io/example   True   True     arn:aws:kafka:us-east-1:12345678910:cluster/example/cef294f9-8e22-4342-9bfd-9635fcaeaebb-9

NAME                                                          READY   SYNCED   EXTERNAL-NAME
configuration.kafka.aws.crossplane.io/example-configuration   True    True     arn:aws:kafka:us-east-1:12345678910:configuration/example-configuration/73a88bf4-8aee-485e-b004-a788735643d4-9

[chlunde]

would defaulting this parameter to the object name provide backwards compatibility? Would it make sense?

[haarchri]

problem is for people using compositions - the cr.name is complete different

[abrarcci]

FYI - have tested out the new changes @haarchri and the msk cluster is now being provisioned, thank you!

One point to note, doing a describe on the cluster gives the following:

  Warning  CannotObserveExternalResource  3m22s (x60 over 58m)  managed/cluster.kafka.aws.crossplane.io  failed to describe Cluster: InvalidParameter: 1 validation error(s) found.
- missing required field, DescribeClusterInput.ClusterArn.

And the status of the cluster never changes from this:

Status:
  At Provider:
  Conditions:
    Last Transition Time:  2023-01-17T12:50:14Z
    Reason:                Creating
    Status:                False
    Type:                  Ready
    Last Transition Time:  2023-01-17T12:50:14Z
    Message:               observe failed: failed to describe Cluster: InvalidParameter: 1 validation error(s) found.
- missing required field, DescribeClusterInput.ClusterArn.

[haarchri]

Yes we found the same we will update shortly

[haarchri]

we will publish tomorrow a new fix release #1638