Fix kafka input clusterName

[haorenfsa]

Signed-off-by: shaoyue.chen [email protected]

Description of your changes

A follow-up of #1612

The external-name should be the uniq id of the resource. Usually we use the Arn of the resource provided by AWS.
The ClusterName is the user defined name. Which is currently not offered in parameters. It's reasonable to use the name of CR as the ClusterName.

Fixes #1611

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

[abrarcci]

Could we get an approval on this one please? Many Thanks

[haorenfsa]

@haarchri take a look?

[haarchri]

I will take a look but cr.name we normally Not using - i guess the original problem is around the initializer

[haorenfsa]

The key is that we need a clusterName for the createCluster input, but the Parameters struct for Cluster.kafka does not provide it.
So I think we've got 2 choices:

1. Use the CR name
2. Add ClusterName in Parameters

[haarchri]

created the following PR #1624 - the problem is when we using cr.name directly - people using compositions and the cr.name is generated per default - so its better to use clusterName in spec

[haorenfsa]

created the following PR #1624 - the problem is when we using cr.name directly - people using compositions and the cr.name is generated per default - so its better to use clusterName in spec

Good point. I agree with u. I'll close this.