feat(rds): instance + cluster allowMajorVersionUpgrade #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
requested changes
Dec 14, 2022
| @@ -424,6 +446,53 @@ func compareTimeRanges(format string, expectedWindow *string, actualWindow *stri | |||
| return false, nil | |||
| } | |||
|
|
|||
| func compareVPCSecurityGroupIDs(cr *svcapitypes.DBInstance, out *svcsdk.DBInstance) bool { | |||
There was a problem hiding this comment.
The return value is easy to misunderstand. Maybe change it to isEqualVPCSecurityGroup.
There was a problem hiding this comment.
Nice to hear. I was initially unsure if or how I should use this more commonly used return logic in this existing resource.
Hopefully the newly committed change compromises not to much.
wotolom
force-pushed
the
rdsinstane-allow-major-version-upgrade
branch
from
8c6cbb4 to
3131a61
Compare
This comment was marked as outdated.
This comment was marked as outdated.
wotolom
force-pushed
the
rdsinstane-allow-major-version-upgrade
branch
from
48f7d8d to
dd12a90
Compare
MisterMX
requested changes
Dec 20, 2022
added 2 commits
December 20, 2022 09:54
Signed-off-by: Charel Baum <[email protected]>
Signed-off-by: Charel Baum <[email protected]>
wotolom
force-pushed
the
rdsinstane-allow-major-version-upgrade
branch
from
dd12a90 to
9fc98b3
Compare
MisterMX
approved these changes
Dec 20, 2022
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
to both DBInstance and DBCluster
allowMajorVersionUpgrade(+ special update handling needed for DBCluster)VPCSecurityGroupIDsandDBParameterGroupName/DBClusterParameterGroupNameFixes #1330
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
manual tests (DBInstance; DBCluster with DBInstance)