Skip to content

Commit

Permalink
fix(dbinstance): correct return values
Browse files Browse the repository at this point in the history
Signed-off-by: Charel Baum <[email protected]>
  • Loading branch information
Charel Baum committed Dec 20, 2022
1 parent 226faec commit 9fc98b3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/controller/rds/dbinstance/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -484,13 +484,13 @@ func areVPCSecurityGroupIDsUpToDate(cr *svcapitypes.DBInstance, out *svcsdk.DBIn
// if user is fine with default SG or lets DBCluster manage it
// (removing all SGs is not possible, AWS will keep last set SGs)
if len(desiredIDs) == 0 {
return false
return true
}

actualGroups := out.VpcSecurityGroups

if len(desiredIDs) != len(actualGroups) {
return true
return false
}

actualIDs := make([]string, 0, len(actualGroups))
Expand Down

0 comments on commit 9fc98b3

Please sign in to comment.