fix(elbv2/target): Retry registration if target is unused #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erickfaustino can you check if this fix solves your issue? |
|
Sure, @MisterMX. |
|
@erickfaustino you can check out the branch and run provider-aws locally with your kube context using |
|
Ok, I will execute the tests and then I will post it here, thank you very much! |
|
@MisterMX, I have tested it, and it worked! The targets are being registered now! Thank you very much! |
MisterMX
force-pushed
the
fix/elbv2-target-not-registered
branch
2 times, most recently
from
9cada9d to
e22ce6f
Compare
Fixes crossplane-contrib#1458 Signed-off-by: Maximilian Blatt <[email protected]> (external expert on behalf of DB Netz AG)
MisterMX
force-pushed
the
fix/elbv2-target-not-registered
branch
from
e22ce6f to
3156129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1458
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually