fix(elbv2/target): Retry registration if target is unused

Fixes #1458 Signed-off-by: Maximilian Blatt <[email protected]> (external expert on behalf of DB Netz AG)
crossplane-contrib · Oct 17, 2022 · 9cada9d · 9cada9d
1 parent 9825b1f
commit 9cada9d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/apis/elbv2/manualv1alpha1/target.go b/apis/elbv2/manualv1alpha1/target.go
@@ -194,6 +194,13 @@ func (s *TargetObservation) GetState() string {
 	return ""
 }
 
+func (s *TargetObservation) GetReason() string {
+	if s.TargetHealth != nil && s.TargetHealth.Reason != nil {
+		return *s.TargetHealth.Reason
+	}
+	return ""
+}
+
 // TargetStatus defines the observed state of a
 // Target
 type TargetStatus struct {

diff --git a/pkg/controller/elbv2/target/controller.go b/pkg/controller/elbv2/target/controller.go
@@ -130,7 +130,7 @@ func (e *external) Observe(ctx context.Context, mg resource.Managed) (managed.Ex
 	}
 
 	return managed.ExternalObservation{
-		ResourceExists:   true,
+		ResourceExists:   cr.Status.AtProvider.GetReason() != string(types.TargetHealthReasonEnumNotRegistered),
 		ResourceUpToDate: true, // Targets cannot be updated
 	}, nil
 }