preflight: add check to see if admin-helper namedpipe is accessible #3642
Conversation
currently we only check if the admin-helper service is running, but it could happen that the service is running but current user is not in the 'crc-users' group, in this case directly trying to access the admin-helper api is better
|
@anjannath: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -118,7 +118,7 @@ var adminHelperServiceCheks = []Check{ | |||
| configKeySuffix: "check-admin-helper-service-running", | |||
| checkDescription: "Checking admin helper service is running", | |||
| check: checkIfAdminHelperServiceRunning, | |||
| fixDescription: "Make sure you installed crc using the Windows installer", | |||
| fixDescription: "Make sure you installed crc using the Windows installer and performed required reboot", | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
currently we only check if the admin-helper service is running, but it could happen that the service is running but current user is not in the 'crc-users' group, in this case directly trying to access the admin-helper api is better
will be helpful for crc-org/crc-extension#93