Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After installation reboot msg box is concealed by preset selection msg box #93

Closed
anjannath opened this issue May 9, 2023 · 3 comments · Fixed by #110
Closed

After installation reboot msg box is concealed by preset selection msg box #93

anjannath opened this issue May 9, 2023 · 3 comments · Fixed by #110

Comments

@anjannath
Copy link
Member

anjannath commented May 9, 2023

Versions

OS: Windows 10 Pro
podman-desktop:  built from master
CRC extension: ghcr.io/crc-org/crc-extension:latest

After finishing the installation for CRC to work, we need to reboot the machine, while doing the installation from the extension/podman-desktop this is notified to the user via a message box that asks user to reboot, but after a few seconds of showing the msg box a new msg box is shown asking the user to select a preset and once selection is made or cancelled in which case the default preset is used, it goes on to download the bundle.

Screen recording of the above flow

reboot_msg_blocked_by_preset_msg.webm

Trying to start CRC and go on with the suggested flow will eventually lead to the following error:
extension_setup_needs_reboot

Q: Should we wait till the user reboots to show the preset selection msg box next time podman-desktop is started? as without a reboot user won't be able to use CRC.
Q: Can we put a Reboot button on the msg box that notifies the user to just click and reboot the machine?

@gbraad
Copy link
Contributor

gbraad commented May 9, 2023

@evidolob WDYT can be done?

@anjannath
Copy link
Member Author

Jeff pointed to the following line of code, (copied from #95)

extensionApi.window.showInformationMessage(

@gbraad
Copy link
Contributor

gbraad commented May 9, 2023

It returns true to indicate the installation successfully finished. In this case you might need a tri-state; true, false, not-really for the situation of a needed reboot.

@gbraad gbraad removed the question label May 9, 2023
jeffmaury added a commit to jeffmaury/crc-extension that referenced this issue May 12, 2023
gbraad pushed a commit that referenced this issue May 15, 2023
@github-project-automation github-project-automation bot moved this from Scheduled to Done in Project planning: crc May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants