Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how chainId is handled #3

Closed
anxolin opened this issue Apr 3, 2022 · 0 comments · Fixed by #8
Closed

Improve how chainId is handled #3

anxolin opened this issue Apr 3, 2022 · 0 comments · Fixed by #8

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 3, 2022

Description

Currently the chainId is passed in the SDK constructor and there's no way to change it either manually or automatically (detect provider's network change). This is cumbersome as the client needs to instantiate one SDK per network, and also it can cause issues when the provider/signer changes the active network.

Solution

Provide a simpler way to create one SDK instance and add a setter to update the chainId and also handlers to react to a provider's change.

Original issue gnosis/cow-sdk#12 by @ramirotw

shoom3301 added a commit that referenced this issue Feb 28, 2023
[SDK refactoring #3] Order-book code generated from Swagger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant