Callbacks Eureka #7934
Callbacks Eureka #7934
Conversation
| @@ -295,7 +295,7 @@ func (s *CallbacksTestSuite) AssertHasExecutedExpectedCallbackWithFee( | |||
|
|
|||
| // GetExpectedEvent returns the expected event for a callback. | |||
| func GetExpectedEvent( | |||
| ctx sdk.Context, packetDataUnmarshaler porttypes.PacketDataUnmarshaler, remainingGas uint64, data []byte, srcPortID, | |||
|
|
||
| return IBCMiddleware{ | ||
| app: packetDataUnmarshalerApp, | ||
| writeAckWrapper: writeAckWrapper, |
There was a problem hiding this comment.
i allow writeAckWrapper to be nil and use chanKeeperV2 if so. cc: @srdtrk for feedback
| TimeoutHeight: clienttypes.Height{}, | ||
| TimeoutTimestamp: 0, |
There was a problem hiding this comment.
timeout values zeroed out everywhere. So we preserve interface, but contracts should not rely on these values for v2 packets
| TimeoutHeight: clienttypes.Height{}, | ||
| TimeoutTimestamp: 0, | ||
| } | ||
| // wrap the individual acknowledgement into the channeltypesv2.Acknowledgement since it implements the exported.Acknowledgement interface |
There was a problem hiding this comment.
wrapping in v2.Acknowledgement and v2.Acknowledgement implements exported.Acknowledgement interface
This is because the original receivePacket callback expects exported.Acknowledgement
| TimeoutTimestamp: 0, | ||
| } | ||
| return im.contractKeeper.IBCOnAcknowledgementPacketCallback( | ||
| cachedCtx, packetv1, acknowledgement, relayer, cbData.CallbackAddress, cbData.SenderAddress, payload.Version, |
There was a problem hiding this comment.
However, here acknowledgement callback just expects []byte
| var writeAckWrapper api.WriteAcknowledgementWrapper | ||
| if im.writeAckWrapper != nil { | ||
| writeAckWrapper = im.writeAckWrapper | ||
| } else { | ||
| writeAckWrapper = im.chanKeeperV2 | ||
| } |
There was a problem hiding this comment.
cc: @srdtrk this may simplify wiring
|
Description
The following is a cherrypick of relevant commits from #7927
Please pay close attention while reviewing this PR. It is recommended to review the ibc callbacks v1 middleware in parallel and ensure all equivalent checks and logic are being made
closes: #7855
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.