Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callbacks Eureka Conversion #7927

Closed
wants to merge 224 commits into from
Closed

Callbacks Eureka Conversion #7927

wants to merge 224 commits into from

Conversation

AdityaSripal
Copy link
Member

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

sangier and others added 30 commits July 31, 2024 12:05
@sangier @srdtrk
@AdityaSripal @DimitrisJim @colin-axner
Cherry-pick: Add MsgRegisterCounterparty Struct and Handler from ibc-…
8d10fed 
…lite (#6982)

* feat(lite): counterparty client logic (#6307)

* imp: added counterparty client store

* imp: added provide counterparty to proto

* imp: ran 'make proto-all'

* imp: added logic to counterparty client

* imp: fix proto

* imp: fix proto

* imp: ran 'make proto-all'

* feat: finished counterparty client logic

* change counterparty to include custom prefix

* fix imports

* import fixes, review suggestions

* rm lite comment

* applying review suggestions

* add creator tests

* addressing aditya review

* Update proto/ibc/core/client/v1/client.proto

Co-authored-by: DimitrisJim <[email protected]>

* Update modules/core/02-client/types/msgs.go

Co-authored-by: DimitrisJim <[email protected]>

* Update modules/core/keeper/msg_server.go

Co-authored-by: colin axnér <[email protected]>

* addressing jim review

* refactor(proto): use counterparty type in MsgProvideCounterparty. Validate Counterparty type.

* refactor(keys): move Counterparty key to 02-client keys.go

* feat(core): delete creator after registering counterparty.

* chore(core): make GetCreator return a boolean if not found.

* tests(02-client): add tests for counterparty validation.

* tests(02-client): add tests for msg_server provide counterparty handler.

* nit(core): remove stale key for counterparty in host.

* Update modules/core/02-client/keeper/keeper_test.go

---------

Co-authored-by: srdtrk <[email protected]>
Co-authored-by: Aditya Sripal <[email protected]>
Co-authored-by: Stefano Angieri <[email protected]>
Co-authored-by: DimitrisJim <[email protected]>
Co-authored-by: colin axnér <[email protected]>
@DimitrisJim
chore: move status checks from connection verify_* functions to 02-cl…
15f3368 
…ient verify_* functions. (#7006)
@DimitrisJim
chore: split out packet handling rpcs (#7007)
2ff4aa9 
* chore: split out packet handling rpcs

* add keeper, expected interfaces, merkle tweaks.

* add verify functions of client keeper.

* self review
@AdityaSripal
Add versions to packet and create Eureka packet commitment (#6986)
44215f7 
* add versions to packet and separate commitment function

* use IBC Version to switch hashing

* fix build and tests, found bug in switch logic

* add documentation

* improve code docstrings

* address jim review

* rename eureka to v2
@DimitrisJim
Merge branch 'main' into feat/ibc-eureka
c1f0e4e
@DimitrisJim @AdityaSripal
feat(tests): add helper functions, keeper test suite. (#7052)
dcff30b 
* feat(tests): add helper functions, keeper test suite.

* wire up packet server in app

---------

Co-authored-by: Aditya Sripal <[email protected]>
@AdityaSripal
feat(core/eureka): add packet handler (#7048)
567e730 
* send packet eureka

* test progress

* add tests

* lint

* nit

* lint moar

* refactor tests
@DimitrisJim
feat(core/eureka): add recv handler (#7041)
94ad62a 
* feat(core/eureka): add recv handler.

* review: address feedback, self review.

* tests(core/packet-server): add tests for recv.

* chore: make lint-fix.

* chore: address review nits.
@AdityaSripal
feat(core/eureka): add timeout handler (#7060)
8c3a9a4 
* timeout eureka implementation

* test progress

* continued progress with tests

* tests

* cleanup and docs

* use sentinel channel in sendPacket events

* address review

* test review fixes

* lint
@DimitrisJim
feat(core/eureka): add writeack, ack handler. (#7049)
2b8a96d 
* feat(core/eureka): add writeack, ack handler.

* tests(core/packet-server): add tests for write acknowledgement.

* chore: add packet protocol version checks to both.

* fix: add check for packet receipt being present.

* tests(core/packet-server): add tests for ack.

* tests: address review, add FreezeClient helper to endpoint.
@DimitrisJim
Merge branch 'main' into feat/ibc-eureka
8a499b1
@DimitrisJim
feat(core): Wire packet handler to core message server (#7091)
366ab9d 
* chore: return app version in handlers

* add expected keeper interface for packet handler functions.

* add switch in msg_server to dispatch based on protocol version.

* guard TimeoutExecuted with version check for time being.

* rename interface.

* inline timeoutExecuted

* slipped WriteAck.

* use msg-server entrypoints for packet flow in testing.

* use endpoint.SendPacket in recv test.
@crodriguezvega
feat(eureka): fix condition in commit packet, added test for zero tim…
2a07e6e 
…eout height (#7109)

* fix condition in commit packet, added test for zero timeout height, change some error messages and add some more comments

* error for verify functions
@colin-axner
refactor: reduce channel lookup for timeout flow (#7149)
0743c09
@colin-axner @crodriguezvega
imp: require stricter usage of app version in packet (#7146)
6efbdec 
* fix: add validation of protocol version and app version to packet validatebasic

* Update modules/core/04-channel/types/packet_test.go

* Update modules/core/04-channel/types/packet.go

Co-authored-by: Carlos Rodriguez <[email protected]>

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
@colin-axner
chore: remove unnecessary comments (#7155)
eb2830f
@colin-axner @AdityaSripal
imp: add tests for BuildMerklePath, make merkle path non-nullable in …
0a9b799 
…counterparty (#7160)

* refactor: regenerate merkle path as non-nullable + add tests to build merkle path

* fix: avoid mutating prefix provided

* fix test build

---------

Co-authored-by: Aditya Sripal <[email protected]>
@colin-axner @AdityaSripal
chore: add godoc to packet server handlers (#7156)
1971ad5 
* chore: add godoc

* Apply suggestions from code review

---------

Co-authored-by: Aditya <[email protected]>
@crodriguezvega
Merge branch 'main' into feat/ibc-eureka
a673f74
@crodriguezvega
feat(eureka): add tests for MsgProvideCounterparty (#7179)
a7c3de4 
* add tests for MsgProvideCounterparty ValidateBasic

* address review comments
@chandiniv1
add submodule to logger (#7196)
88f6a3f 
* add submodule for  logger

* add submodule in keys.go
@colin-axner @AdityaSripal @crodriguezvega
tests: msg server tests for eureka (#7162)
ad5748e 
* test: TestAcknowledgePacketV2

* fix up recv tests

* add timeout v2 tests

* imp: use expErr instead of expPass

---------

Co-authored-by: Aditya Sripal <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
@crodriguezvega
Merge branch 'main' into feat/ibc-eureka
f34c0f7
@AdityaSripal @crodriguezvega
Validate MerklePathPrefix and Path (#7193)
1c5e886 
* merkle validation funcs

* add merkle prefix validation and testing

* address comments

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
@chandiniv1 @crodriguezvega @DimitrisJim
add helper to retrieve handler and module based on protocol version (#…
e66223c 
…7198)

* add helper to retrieve handler and module based on protocol version

* address self review comments

* returning values instead of binding vars

* chore: clean up case for v1.

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: DimitrisJim <[email protected]>
@vishal-kanna @crodriguezvega @DimitrisJim
feat(eureka): Add gRPC query for Counterparty for a given client iden…
5d62925 
…tifier (#7120)

* chore: add grpc query for counterParty

* chpre: made changes to the proto

* chore: updated goDoc

* chore: added creator to the respone

* fix: fixes in the grpc_query

* fixes

* improve implementation and add tests

* trying to fix weird linter error

* fix build

* chore: make counterparty field of response a non pointer.

* chore: simplify logic, remove uneeded ifs

* chore(tests): use expError pattern.

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: DimitrisJim <[email protected]>
@vishal-kanna @crodriguezvega
feat(eureka): add CLI to submit MsgProvideCounterparty (#7118)
ed164c3 
* wip

* wip

* chore: added description

* fix: fixed lint issues

* address my self-review

* lint

* accept hex-encoded strings for merkle path prefix

* fix build error

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
@chandiniv1 @crodriguezvega
Use client and counterparty terminology in packet server (#7195)
f4783d1 
* Use client and counterparty terminology in packet server rather than channel

* add counterparty not found error

* add ErrCounterpartyNotFound

* improve comment

---------

Co-authored-by: Carlos Rodriguez <[email protected]>
@DimitrisJim
chore: require app version be non-empty when protocol version is vers…
8a324c2 
…ion 2 (#7209)

* chore: require app version be non-empty when protocol version is version 2.

* chore(tests): use constructor instead of direct struct initialization.

* chore(tests): update usages in msg_server, packet_server tests to use non-empty app version.
@DimitrisJim
chore(tests): add case for latest height err case. (#7212)
d98549b
srdtrk and others added 12 commits January 24, 2025 11:25
@srdtrk
imp: updated events to remove channels (#7874)
d7d25e6 
* imp: updated channel v2 events

* fix: removed event
@gjermundgaraba
Merge branch 'main' into feat/ibc-eureka
3a4d7b5
@gjermundgaraba
fix: build wasm image on native architecture (#7884)
4ff42e4 
* distribute build on native OS for wasm builds

* fix build-wasm-simd-image-from-tag.yml

* add buildx

* Add install go for macos runner

* setup docker before login

* use linux arm instead of macos

* fix image name

* reference issue in TODO
@AdityaSripal
callbacks middleware compatible for eureka
0219b43
@AdityaSripal
test: add initial eureka transfer tests (#7901)
0d58d59
@gjermundgaraba
fix: enable noop error in v2 timeout (#7903)
088c822
@AdityaSripal @gjermundgaraba
imp: harden ICS20 Eureka Module (#7908)
d53e5d7 
* enforce strict portID check in eureka module

* make base denom check

* fix comments

* lint

* lint moar

* one last time

---------

Co-authored-by: Gjermund Garaba <[email protected]>
@srdtrk @gjermundgaraba
imp: drop solidity-ibc-eureka dependency (#7909)
76d0407 
* imp: abi decoding

* imp: removed abigen

---------

Co-authored-by: Gjermund Garaba <[email protected]>
@AdityaSripal
imp: use constant error acknowledgement
95a78d8
@AdityaSripal
Merge branch 'feat/ibc-eureka' of github.com:cosmos/ibc-go into adity…
d4f586d 
…a/callbacks-eureka
@AdityaSripal
convert v2 packets to v1 to preserve contractKeeper interface
8fb1648
@AdityaSripal
remove ContractKeeperV2 interface
a46b077
@AdityaSripal AdityaSripal changed the base branch from aditya/callbacks-eureka to feat/ibc-eureka February 6, 2025 20:25
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
1 Security Hotspot
66.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@AdityaSripal AdityaSripal marked this pull request as draft February 6, 2025 22:37
Base automatically changed from feat/ibc-eureka to main February 7, 2025 17:48
@AdityaSripal AdityaSripal mentioned this pull request Feb 7, 2025
Open
10 tasks
@AdityaSripal
Copy link
Member Author

Superceded by #7934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.