Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CreateValidator and EditValidator in REST #5182

Merged
merged 11 commits into from
Oct 16, 2019
Merged

Add CreateValidator and EditValidator in REST #5182

merged 11 commits into from
Oct 16, 2019

Conversation

preminem
Copy link

@preminem preminem commented Oct 11, 2019 •
edited by fedekunze
Loading

Closes #5113

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze
fedekunze reviewed Oct 11, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @preminem this looks great. I have one question only. Also, could you add an entry on the CHANGELOG.md under ### Features with a * (rest) tag 🙏 ?

x/staking/client/rest/tx.go Outdated
ValidatorAddress sdk.ValAddress `json:"address" yaml:"address"`
Description types.Description `json:"description" yaml:"description"`
CommissionRate *sdk.Dec `json:"commission_rate" yaml:"commission_rate"`
MinSelfDelegation *sdk.Int `json:"min_self_delegation" yaml:"min_self_delegation"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this struct has a pointer while MinSelfDelegation from CreateValidatorRequest doesn't. Why the difference ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an oversight and has been fixed.I also added change log as you said.

alexanderbez
alexanderbez suggested changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you @preminem!

We're completely revamping our swagger documentation. Would you mind rebasing and targetting this PR against bez/2179-auto-swagger instead of master? Add the annotations to createValidatorHandlerFn.

@codecov
Copy link

codecov bot commented Oct 12, 2019 •
edited
Loading

Codecov Report

Merging #5182 into bez/2179-auto-swagger will increase coverage by 0.01%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##           bez/2179-auto-swagger    #5182      +/-   ##
=========================================================
+ Coverage                  53.35%   53.36%   +0.01%     
=========================================================
  Files                        290      290              
  Lines                      17696    17696              
=========================================================
+ Hits                        9441     9443       +2     
+ Misses                      7518     7516       -2     
  Partials                     737      737

@preminem preminem changed the base branch from master to bez/2179-auto-swagger October 12, 2019 06:42
@preminem preminem closed this Oct 12, 2019
@preminem preminem reopened this Oct 12, 2019
@preminem
Copy link
Author

Amazing, thank you @preminem!

We're completely revamping our swagger documentation. Would you mind rebasing and targetting this PR against bez/2179-auto-swagger instead of master? Add the annotations to createValidatorHandlerFn.

Done. But the corresponding swagger documentation still needs some work.

alexanderbez
alexanderbez suggested changes Oct 14, 2019
View reviewed changes
preminem and others added 5 commits October 15, 2019 20:54
@preminem @alexanderbez
Update CHANGELOG.md
b077609 
Co-Authored-By: Alexander Bezobchuk <[email protected]>
@preminem @alexanderbez
Update x/staking/client/rest/tx.go
1a145d6 
Co-Authored-By: Alexander Bezobchuk <[email protected]>
@preminem @alexanderbez
Update x/staking/client/rest/tx.go
321918c 
Co-Authored-By: Alexander Bezobchuk <[email protected]>
@preminem @alexanderbez
Update x/staking/client/rest/tx.go
2a0726e 
Co-Authored-By: Alexander Bezobchuk <[email protected]>
Fix editValidatorHandler
1e3bcbf
@preminem @golangcibot
Update x/staking/client/rest/tx.go
f6871ac 
Co-Authored-By: Bot from GolangCI <[email protected]>
alexanderbez
alexanderbez approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@alexanderbez alexanderbez merged commit b68e9c0 into cosmos:bez/2179-auto-swagger Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze left review comments

@golangcibot golangcibot golangcibot left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@preminem @alexanderbez @fedekunze @golangcibot