Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateValidator and EditValidator in REST #5113

Closed
2 of 4 tasks
preminem opened this issue Sep 30, 2019 · 4 comments
Closed
2 of 4 tasks

Add CreateValidator and EditValidator in REST #5113

preminem opened this issue Sep 30, 2019 · 4 comments

Comments

@preminem
Copy link

preminem commented Sep 30, 2019

Summary

add createValidator and editValidator handler in x/staking/client/rest

Problem Definition

REST client lacks these two function contained in CLI

Proposal

  1. Add these two handler in x/staking/client/rest/tx.go
  2. Add Swagger annotations

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez alexanderbez changed the title Add CreateValidator and EditValidator for LCD Add CreateValidator and EditValidator in REST Sep 30, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 5, 2020
@tac0turtle tac0turtle added pinned and removed stale labels Jul 6, 2020
@dauTT
Copy link
Contributor

dauTT commented Jul 23, 2020

Hi, I see that @preminem was working on this issue and created a PR to a separate branch. Why the PR request was not merge to the master branch?

@alexanderbez
Copy link
Contributor

Don't bother @dauTT -- the legacy API is being deprecated. However, you can verify that we have these handlers for the gRPC service. If not, feel free to add them!

@tac0turtle
Copy link
Member

rest is now gone, these methods are exposed on grpc though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants