Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README and build: add info on testing modified script locally, and boldness to build output error #237

Merged
merged 2 commits into from
Nov 26, 2018
Merged

README and build: add info on testing modified script locally, and boldness to build output error #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce101ae
README: add info on locally editing scripts and building image
Nov 26, 2018
9e05a6a
build: add error and boldness for missing submodule message
Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,3 +122,21 @@ Development
---

The container image is built in [OpenShift CI](https://api.ci.openshift.org/console/project/rhcos/browse/builds/coreos-assembler?tab=history).

When editing a script, a quick way to use the locally-modified script in
`coreos-assembler` is to volume-mount the path to the script, for example:

```
$ alias coreos-assembler= podman run --rm --net=host -ti --privileged --userns=host -v $(pwd):/srv -v /path/to/coreos-assembler/src/cmd-run:/usr/lib/coreos-assembler/cmd-run --workdir /srv quay.io/coreos-assembler/coreos-assembler
```

To completely rebuild the coreos-assembler container image locally, execute
`$ podman build .` from the `coreos-assembler` repository. You can upload your
built image to a registry such as quay.io by doing the following:

```
$ podman push <image id> quay.io/<account name>/coreos-assembler
```

Replacing the container image argument in the `coreos-assembler` alias with
`quay.io/<account name>/coreos-assembler` will pull your container image instead.
2 changes: 1 addition & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ make_and_makeinstall() {
rsync -rlv "${srcdir}"/ostree-releng-scripts/ /usr/app/ostree-releng-scripts/

if ! test -f mantle/README.md; then
echo "Run: git submodule update --init" 1>&2
echo -e "\033[1merror: submodules not initialized. Run: git submodule update --init\033[0m" 1>&2
exit 1
fi

Expand Down