Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README and build: add info on testing modified script locally, and boldness to build output error #237

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

rfairley
Copy link
Contributor

@rfairley rfairley commented Nov 26, 2018

Just some notes I made while hacking on this before, in case they can be of use.

The boldness edit to the build error is not very crucial, as with the script already being printed out it was quick to get the problem resolved. But adding the error: or something like that I find helps it stick out a bit when looking for what went wrong.

rfairley added 2 commits November 26, 2018 11:26
Some notes I made while previously hacking in order to test
my changes - in case others find useful.
Minor but caught me for a minute, boldness helps it to pop out.
@dustymabe
Copy link
Member

i've been planning to PR some docs notably a variation between the docker and podman path and also to document the bash hackery I've got for auto mounting in things. This looks good for now. I'll add a PR in the future and request @rfairley to review too.

@dustymabe dustymabe merged commit e2ccef7 into coreos:master Nov 26, 2018
@rfairley
Copy link
Contributor Author

Thanks @dustymabe ! The auto-mounting way sounds interesting, will be handy.

@cgwalters
Copy link
Member

Isn't this #182 ? I haven't tried it though myself.

@dustymabe
Copy link
Member

Isn't this #182 ? I haven't tried it though myself.

yes. although I think there should be documentation for "alias mode" and for bottlecap.

@rfairley rfairley deleted the rfairley-readme-edits branch December 7, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants