kola/spawn: enable internet access #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from coreos#1514. `kola spawn` is for users, so just always enable Internet access there. In the future we could have `--no-net` control this knob too if the need arises. This is needed by the rpm-ostree CI which uses `kola` to bring up nodes.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgilbert, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Also I realize the contradiction between:
and
I guess I should've qualified the first sentence with "mostly for users" now that we have e.g. coreos/mantle#1079. There's also work in rpm-ostree to convert some tests to the new external host tests layout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #1514.
kola spawnis for users, so just always enableInternet access there. In the future we could have
--no-netcontrolthis knob too if the need arises.
This is needed by the rpm-ostree CI which uses
kolato bring up nodes.