tests: Enforce no Internet in qemu unless flagged #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
draft/WIP until #1478 merges and we also fix the tests. |
|
Also we can extend this to non-qemu - e.g. in AWS we can create a restricted VPC or so. |
In coreos#1478 we discussed Internet access and tests, adding a flag to disable tests which are flagged as requiring it. This flips things around and *enforces* no Internet access for qemu tests by default unless the test is flagged as requiring it. Unsurprisingly it turns out several tests are missing the flag. Another issue here is that external tests don't have a way to influcence flags. Continuing our "mimic Debian autopkgtest where applicable" trend, support a `needs-internet` tag, which works for external tests since they can provide flags.
cgwalters
force-pushed
the
test-enforce-nonet
branch
from
4e40ec6 to
25710d4
Compare
|
OK, lifting WIP on this! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Jul 16, 2020
Regression from coreos#1514. `kola spawn` is for users, so just always enable Internet access there. In the future we could have `--no-net` control this knob too if the need arises. This is needed by the rpm-ostree CI which uses `kola` to bring up nodes.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jul 16, 2020
Regression from #1514. `kola spawn` is for users, so just always enable Internet access there. In the future we could have `--no-net` control this knob too if the need arises. This is needed by the rpm-ostree CI which uses `kola` to bring up nodes.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Jul 17, 2020
Since it turns out I broke the ostree tests after coreos#1514
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Jul 17, 2020
Since it turns out I broke the ostree tests after coreos#1514
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jul 17, 2020
Since it turns out I broke the ostree tests after #1514
kelvinfan001
pushed a commit
to kelvinfan001/coreos-assembler
that referenced
this pull request
Jul 17, 2020
Regression from coreos#1514. `kola spawn` is for users, so just always enable Internet access there. In the future we could have `--no-net` control this knob too if the need arises. This is needed by the rpm-ostree CI which uses `kola` to bring up nodes.
kelvinfan001
pushed a commit
to kelvinfan001/coreos-assembler
that referenced
this pull request
Jul 17, 2020
Since it turns out I broke the ostree tests after coreos#1514
kelvinfan001
pushed a commit
to kelvinfan001/coreos-assembler
that referenced
this pull request
Jul 17, 2020
Regression from coreos#1514. `kola spawn` is for users, so just always enable Internet access there. In the future we could have `--no-net` control this knob too if the need arises. This is needed by the rpm-ostree CI which uses `kola` to bring up nodes.
kelvinfan001
pushed a commit
to kelvinfan001/coreos-assembler
that referenced
this pull request
Jul 17, 2020
Since it turns out I broke the ostree tests after coreos#1514
kelvinfan001
pushed a commit
to kelvinfan001/coreos-assembler
that referenced
this pull request
Jul 17, 2020
Regression from coreos#1514. `kola spawn` is for users, so just always enable Internet access there. In the future we could have `--no-net` control this knob too if the need arises. This is needed by the rpm-ostree CI which uses `kola` to bring up nodes.
kelvinfan001
pushed a commit
to kelvinfan001/coreos-assembler
that referenced
this pull request
Jul 17, 2020
Since it turns out I broke the ostree tests after coreos#1514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1478 we
discussed Internet access and tests, adding a flag to disable
tests which are flagged as requiring it.
This flips things around and enforces no Internet access for
qemu tests by default unless the test is flagged as requiring
it.
Unsurprisingly it turns out several tests are missing the flag.
(And we also don't presently have a way to flag external tests
as requiring Internet, which is another issue)