Python dependency sync check is never executed in CI/CD workflow #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The step “Check that compiled Python dependency manifests are up-to-date with their sources” is supposed to run only for the lowest supported Python version (currently 3.8). However, commit 751adb0 inadvertently disabled this step for all Python versions because of an incorrect string comparison (`3.8.` is not a substring of `3.8`).
jtrobles-cdd
force-pushed
the
bugfix/ci-cd-python-deps-sync-check
branch
from
ae5ef03 to
6cb9da3
Compare
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The step “Check that compiled Python dependency manifests are up-to-date with their sources” is supposed to run only for the lowest supported Python version (currently 3.8). However, commit 751adb0 from pull request #748 inadvertently disabled this step for all Python versions because of an incorrect string comparison (
3.8.is not a substring of3.8).