Skip to content

Commit ae5ef03

Browse files
committed
fix: Python dependency sync check is never executed in CI/CD workflow
The step *Check that compiled Python dependency manifests are up-to-date with their sources* is supposed to run only for the lowest supported Python version (currently 3.8). However, commit 751adb0 inadvertently disabled this step for all Python versions because of an incorrect string comparison (`3.8.` is not a substring of `3.8`).
1 parent 4bebcd5 commit ae5ef03

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ jobs:
138138

139139
- name: Check that compiled Python dependency manifests are up-to-date with their sources
140140
# FIXME: There are issues related to testing with multiple Python versions.
141-
if: ${{ startsWith(matrix.python_version, '3.8.') }}
141+
if: ${{ startsWith(steps.set_up_python.outputs.python-version, '3.8.') }}
142142
run: |
143143
source "$PYTHON_VIRTUALENV_ACTIVATE"
144144
make python-deps-sync-check

0 commit comments

Comments
 (0)