add chromedp.NewRemoteAllocatorWithHeader #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening this PR just for discussing the changes, not intending to merge this.
In this branch, the
wsHeader
is passed via parameters all the way down to theDialContext
function.The header can be set like this:
actx, acancel := chromedp.NewRemoteAllocator(ctx, wsUrl, wsHeader)
No public functions are changed, instead
XxxWithHeader
functions are added where needed.Pros
BrowserOption
etc.)Cons ?
This is the branch that is currently used by github.com/contextflow/cf-dicom-report-service.
Todo: