add DialOption for adding a header #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Hope they'll accept the PR eventually. I guess we'd have to update docs and tests there as well. The devs of chromedp are very responsive fyi. |
flicaflow
reviewed
Jul 31, 2023
| @@ -30,6 +31,8 @@ type Allocator interface { | |||
| // Cancelling the allocator context will already perform this operation, | |||
| // so normally there's no need to call Wait directly. | |||
| Wait() | |||
|
|
|||
| getDialHeader() http.Header | |||
There was a problem hiding this comment.
Sure we need this private method in the Interface? This is usually for external use, internally we should have access to the real implementation ad not through the interface
flicaflow
reviewed
Jul 31, 2023
| @@ -583,6 +592,7 @@ func (a *RemoteAllocator) Allocate(ctx context.Context, opts ...BrowserOption) ( | |||
| a.wg.Done() | |||
| }() | |||
|
|
|||
| opts = append(opts, WithDialHeaderBrowser(FromContext(ctx).Allocator.getDialHeader())) | |||
There was a problem hiding this comment.
I see why we need it in the interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening this PR just for discussing the changes, not intending to merge this.
Todo: