-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the Preview API #31
Merged
floriank
merged 3 commits into
contentful-userland:master
from
floriank:adds-preview-api
Jun 12, 2020
Merged
Adds the Preview API #31
floriank
merged 3 commits into
contentful-userland:master
from
floriank:adds-preview-api
Jun 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 859394d66e575354d39b8385f3b608a2c317efd8-PR-31
💛 - Coveralls |
Pull Request Test Coverage Report for Build f13553ecca52a1748ea562665207c0d72df5bbb3-PR-31
💛 - Coveralls |
Closed
859394d
to
138347c
Compare
also adds some dummy code for entries
Basically omits a separate implementation for the CPA and just uses a configurable endpoint. The endpoint can take a custom url too, in case we ever need to roll out a CDA feature complete non-CPA system.
138347c
to
f13553e
Compare
asaaki
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting and cheap approach. Feels a bit hacky, but if it works I'm okay with it. Will probably be fine for 99% of the use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Preview API by using
Contentful.Preview
as a namespace for holding the same structures asContentful.Delivery
This is also meant for refactoring out the Request code from the modules, as @asaaki suggested in #18.It's a WIP for the moment, as I have to move a bunch of code. The generic idea is as follows:Edit: Scratch that, it's easier to just follow the idea from @zaeemarshad in #9.
This also closes #9 if successful.