Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable endpoint #13

Closed
wants to merge 9 commits into from
Closed

Configurable endpoint #13

wants to merge 9 commits into from

Conversation

zaeemarshad
Copy link

  • Move functions to Contentful.Functions module
  • Create new modules for delivery and preview with endpoints as module attributes

TODO: Write tests for preview.

@dlitvakb
Copy link
Collaborator

Hey @zaeemarshad,

This looks really good,

Please let me know when it's done and I can test it and merge it.

Cheers

@zaeemarshad
Copy link
Author

@dlitvakb thanks. This is ready to go as there are no changes needed at the moment. I'd appreciate if you can merge it now. I will be contributing to the test code later.

@zaeemarshad
Copy link
Author

@dlitvakb So I have added tests for Preview which is basically the same as Delivery. If you can add some content in draft state to your space and capture it in a cassette, a test can be written that uses Preview to check draft data.

I have also cleaned up the folder structure to better reflect the module division. Let me know your thoughts.

@zaeemarshad
Copy link
Author

@dlitvakb any update on the merge?

@dlitvakb
Copy link
Collaborator

Hey @zaeemarshad,

I'm currently working on adding more verbose errors to all main SDKs I maintain, as soon as I finish that, which should be between today and tomorrow. I have some free time to take a look into this.

Cheers

@asaaki
Copy link
Collaborator

asaaki commented May 12, 2020

@floriank do we want to close the PR as they are relying on an old version of the code?

@floriank
Copy link
Collaborator

Closing, as this will be superseded by #31

@floriank floriank closed this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants