-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable endpoint #13
Configurable endpoint #13
Conversation
Add configurable endpoint option
…and preview; replace rstring with trim_trailing
Configurable endpoint
Hey @zaeemarshad, This looks really good, Please let me know when it's done and I can test it and merge it. Cheers |
@dlitvakb thanks. This is ready to go as there are no changes needed at the moment. I'd appreciate if you can merge it now. I will be contributing to the test code later. |
@dlitvakb So I have added tests for Preview which is basically the same as Delivery. If you can add some content in draft state to your space and capture it in a cassette, a test can be written that uses Preview to check draft data. I have also cleaned up the folder structure to better reflect the module division. Let me know your thoughts. |
@dlitvakb any update on the merge? |
Hey @zaeemarshad, I'm currently working on adding more verbose errors to all main SDKs I maintain, as soon as I finish that, which should be between today and tomorrow. I have some free time to take a look into this. Cheers |
@floriank do we want to close the PR as they are relying on an old version of the code? |
Closing, as this will be superseded by #31 |
TODO: Write tests for preview.