Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport pull request #2117 to release-1.55 #2159

Merged

Conversation

anderbubble
Copy link
Contributor

@anderbubble anderbubble commented Nov 4, 2024

Backport pull request #2117 to release-1.55.

Update copy.DirCopy to leave sockets in the file system

(cherry picked from commit 960e8dd)

Update copy.DirCopy to leave sockets in the file system

(cherry picked from commit 960e8dd)
@anderbubble
Copy link
Contributor Author

@giuseppe is there anything waiting on me towards getting this backport merged?

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anderbubble, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member

@mtrmac PTAL

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c724fb4 into containers:release-1.55 Nov 14, 2024
18 checks passed
@anderbubble anderbubble deleted the backport-2117-to-1.55 branch November 14, 2024 22:20
@anderbubble
Copy link
Contributor Author

Thank for for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants