spec: created_at is a Timestamp. #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @xing-yang @jingxu97 for FYI |
julian-hj
suggested changes
Nov 13, 2018
|
I'm happy to make that change later tonight or tomorrow morning... if
people want it
…On Tue, Nov 13, 2018, 6:47 PM Julian Hjortshoj ***@***.***> wrote:
***@***.**** requested changes on this pull request.
any chance we could rename this field to creation_time or creation_date
while we are changing it? The non-nominal field name kind of bugs me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#331 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACPVLJhb07EUH4CXatMSv1lxC268uezMks5uu1olgaJpZM4YcvOC>
.
|
I'm fine with it too. Go for it. I'll wait for it. |
|
Thanks @jdef! Yes, Jing and I are fine with the change. Renaming it to creation_time sounds good. |
|
@julian-hj I've renamed the field - PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330